Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block pattern dom validation tests #45747

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Add block pattern dom validation tests #45747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0027e4d
WIP: Add pattern validation tests
Jul 30, 2020
4488f77
tmp
Aug 5, 2020
78e2e33
Ignore errors for html5 tags while parsing dom
Sep 18, 2020
fa7098d
Drop unintended changes
Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions .../editing-toolkit/editing-toolkit-plugin/block-patterns/test/class-block-patterns-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
<?php
/**
* Tests for the block-patterns plugin
*
* @package full-site-editing-plugin
*/

namespace A8C\FSE;

use PHPUnit\Framework\TestCase;

require_once __DIR__ . '/../class-block-patterns.php';

// phpcs:disable Generic.Commenting.DocComment.MissingShort,Squiz.Commenting

class Block_Patterns_Test extends TestCase {
/**
* @dataProvider getPatterns
*/
public function test_patterns_pass_dom_validation( $name, $pattern ) {
$prior_use_internal_errors = libxml_use_internal_errors( true );
$dom = new \DOMDocument();
$load_result = $dom->loadHTML( $pattern['content'] );
$errors = libxml_get_errors();
libxml_clear_errors();
libxml_use_internal_errors( $prior_use_internal_errors );

// Overenthusiastically filter out HTML 5 tag errors
// http://www.xmlsoft.org/html/libxml-xmlerror.html#xmlParserErrors
// XML_HTML_UNKNOWN_TAG = 801 : 801
$errors = array_filter(
$errors,
function( $error ) {
if ( 801 !== $error->code ) {
return true;
};

$html5_elements = array(
'article',
'aside',
'bdi',
'details',
'dialog',
'figcaption',
'figure',
'footer',
'header',
'main',
'mark',
'menuitem',
'meter',
'nav',
'progress',
'rp',
'rt',
'ruby',
'section',
'summary',
'time',
'wbr',
// new media elements
'audio',
'embed',
'source',
'track',
'video',
);

preg_match( '/Tag (.*) invalid/', $error->message, $result );
$invalid_tag_name = $result[1] ?? 'Unknown';
return ! in_array( $invalid_tag_name, $html5_elements, true );
}
);

// phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_var_export
$this->assertEmpty( $errors, "Unexpected errors parsing pattern $name: " . var_export( $errors, true ) );
$this->assertTrue( $load_result );
}

public function getPatterns() {
$pattern_data = array();
$patterns = Block_Patterns::get_instance()->get_patterns();
foreach ( $patterns as $name => $details ) {
$pattern_data[] = array( $name, $details );
}

return $pattern_data;
}
}
3 changes: 3 additions & 0 deletions apps/editing-toolkit/editing-toolkit-plugin/phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,8 @@
<testsuite name="default">
<directory suffix="-test.php">./phpunit/</directory>
</testsuite>
<testsuite name="block-patterns">
<directory suffix="-test.php">./block-patterns/test/</directory>
</testsuite>
</testsuites>
</phpunit>