Add block pattern dom validation tests #45747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
deBhal
added
the
Editing Toolkit
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
deBhal
changed the title
Looks like we forgot to update CI to match the new required node version. |
deBhal
force-pushed
the
add/block-pattern-dom-validation-tests
branch
2 times, most recently
from
50779d8
to
3272c21
Compare
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D49908-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
deBhal
force-pushed
the
add/block-pattern-dom-validation-tests
branch
from
3272c21
to
fa7098d
Compare
noahtallen
approved these changes
Sep 22, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
Check the README for setup instructions
In addition to verifying that these tests run green with the current patterns, it would also be good to check that they fail with broken patterns by editing some of the patterns in the
block-patterns/patternsdirectory, as sometimes the tests fail silently (You might also want to runnpx wp-env run phpunit 'phpunit --debug -c /var/www/html/wp-content/plugins/editing-toolkit-plugin/phpunit.xml.dist'inapps/editing-toolkitto verify that the couple of pages as the new test_patterns_pass_dom_validation runs on each pattern.)In particular, it should warn about the missing closing double-quotes that started this off in #43817, as well as catching generally broken html (incorrect/unbalanced tags etc).