-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block pattern dom validation tests #45747
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Looks like we forgot to update CI to match the new required node version. |
50779d8
to
3272c21
Compare
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D49908-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
3272c21
to
fa7098d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the phpunit check:
- Ran successfully
- Reported a many more tests in the results than there were previously
It looks like this is working well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
Changes proposed in this Pull Request
Testing instructions
Check the README for setup instructions
In addition to verifying that these tests run green with the current patterns, it would also be good to check that they fail with broken patterns by editing some of the patterns in the
block-patterns/patterns
directory, as sometimes the tests fail silently (You might also want to runnpx wp-env run phpunit 'phpunit --debug -c /var/www/html/wp-content/plugins/editing-toolkit-plugin/phpunit.xml.dist'
inapps/editing-toolkit
to verify that the couple of pages as the new test_patterns_pass_dom_validation runs on each pattern.)In particular, it should warn about the missing closing double-quotes that started this off in #43817, as well as catching generally broken html (incorrect/unbalanced tags etc).