[GBonWPCOM e2e tests i0] Add assertion for blocks in the frontend (published) page for edge/non-edge, add @parallel tag #45794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullofcaffeine
commented
Sep 22, 2020
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
fullofcaffeine
changed the title
fullofcaffeine
added
the
[Status] Needs e2e Testing Gutenberg Edge
This was referenced Sep 22, 2020
Merged
fullofcaffeine
commented
Sep 22, 2020
sirreal
added
[Status] Needs e2e Testing Gutenberg Edge
4 tasks
fullofcaffeine
commented
Sep 23, 2020
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
WunderBart
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-fill-in-blocks-groundwork
branch
2 times, most recently
from
7da339a
to
39dbff5
Compare
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-fill-in-blocks-groundwork
branch
from
39dbff5
to
8500487
Compare
WunderBart
added
[Status] Needs e2e Testing Gutenberg Edge
…laky sleep)" This reverts commit 7ada50c1613be054d4152123916e65b16a28ac9f.
Doesn't seem to be needed anymore. Saving precious seconds 💥
Gutenberg saves the editor mode in the local storage. When the whole upgrade suite runs in a single browser instnace (i.e when running locally without magellan) it's was bound to fail, since once it re-visited a site, it'd open the editor in the code view, which was unexpected. By deleted the local storage data for the site, once it's re-visited, it then falls-back to the default visual editor, as expected. Also, extract the code to start a new post into its own helper function since it's used in two places at the moment.
We can go directly to a new post on a target site. No need to login each time as it's a single user for all upgrade test sites.
This reverts commit 54e3c9e1acabb537e4d61d2bcf150dca6be5b2e3.
…editors" This reverts commit 67a27cd605072e1b6dde2932d2757618da644ab7.
WunderBart
force-pushed
the
add/gb-upgrade-fill-in-blocks-groundwork
branch
from
3c9441f
to
4ad441f
Compare
WunderBart
added
the
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
commented
Oct 2, 2020
| @@ -391,7 +391,7 @@ export default class GutenbergEditorComponent extends AsyncBaseContainer { | |||
| * You can just import the class of the block(s) you want to add and pass it to this function, which | |||
| * also means we don't need to couple the block class with this one. | |||
| * | |||
| * @param { typeof GutenbergBlockComponent } blockClass A block class | |||
| * @param { Function } blockClass A block class | |||
There was a problem hiding this comment.
This is one of the types I considered, being that it's the constructor for the class, which is a Function. However, we do miss the actual type narrowing here as this suggests it could be any constructor.
I've been searching around and didn't find a definitive answer for that, but got some hints here: jsdoc/jsdoc#1349, and that's why I chose to use typeof GutenbergBlockComponent.
I'm fine leaving this as Function, though, but it'd be interesting to dive a bit deeper into it later if we have time to figure out if there's a proper syntax for this case.
bsessions85
approved these changes
Oct 2, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This is a follow up for #45048. Tracking issue: #45209.
@paralleltag (one per block/edge+non edge site test)has been added so that the test is picked up by magellan/CI and will run faster (< 6min timeout limit);This was extracted from the PR here: #45284. We decided to split it into several PRs, instead. The amount of files changed is the same (due to the static property being added to the block classes with the frontend selector) but the actual changeset is simpler, as the logic for filling/setting-up each block has been extracted into other PRs.
Why
The initial task added the framework/PoC for automating our manual testing process. It only configured two blocks, though. The goal of this PR is to lay the groundwork to later fill in all of the popular blocks being tested as part of the upgrade E2E test, and verify them in the published page too (edge/non-edge and across the most popular themes).
Testing instructions
./node_modules/.bin/mocha specs/wp-calypso-gutenberg-upgrade-spec.js*[0]Needs e2e Testing Gutenberg Edgeto this PR (already added, if necessary, remove and add again);*[0] Make sure to cd into
test/e2efirst.Related PRs
Review and test the following PRs after this PR has been merged: