Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GBonWPCOM e2e tests i0] Setup and fill-in the Slidehow and Gallery Masonry block with sample images #45799

Merged
merged 1 commit into from
Oct 7, 2020
Merged

[GBonWPCOM e2e tests i0] Setup and fill-in the Slidehow and Gallery Masonry block with sample images #45799

merged 1 commit into from
Oct 7, 2020

Conversation

fullofcaffeine
Copy link
Contributor

Changes proposed in this Pull Request

Setup and fill the Slideshow and Gallery Masonry blocks with some sample images. I chose to group them together here because the API is the same.

⚠️ (Preferably) review and test this PR only after #45794 has been merged ⚠️

Testing instructions

  1. Setup your env to run Calypso E2E tests (search for "Automated end-to-end Testing") in the FG;
  2. Run with ./node_modules/.bin/mocha specs/wp-calypso-gutenberg-upgrade-spec.js*[0]
  3. Wait for the tests to finish. It might take a good while since it tests everything for each test site;
  4. Make sure it didn't err, if it did, it might not be an actual failure, try running that specific step again. If it continues failing, let us know.
  5. Add the Needs e2e Testing Gutenberg Edge to this PR (already added, if necessary, remove and add again);
  6. Check this branch's tests in CI: Desktop, Mobile.

*[0] Make sure to cd into test/e2e first.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/gb-upgrade-fill-in-blocks-image-galleriesish

This was referenced Sep 22, 2020
Merged
Closed
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal mentioned this pull request Sep 22, 2020
Closed
4 tasks
@fullofcaffeine fullofcaffeine force-pushed the add/gb-upgrade-fill-in-blocks-image-galleriesish branch 2 times, most recently from 5cec491 to 1b642fd Compare September 23, 2020 01:56
@fullofcaffeine fullofcaffeine self-assigned this Sep 23, 2020
@fullofcaffeine fullofcaffeine added the [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot label Sep 23, 2020
@fullofcaffeine fullofcaffeine force-pushed the add/gb-upgrade-fill-in-blocks-image-galleriesish branch 2 times, most recently from 7996781 to cb40728 Compare September 26, 2020 02:26
@fullofcaffeine fullofcaffeine force-pushed the add/gb-upgrade-fill-in-blocks-image-galleriesish branch 4 times, most recently from 3fd9ef9 to 261e013 Compare October 2, 2020 22:55
@fullofcaffeine fullofcaffeine requested a review from a team October 3, 2020 00:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 3, 2020
@fullofcaffeine fullofcaffeine added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Oct 3, 2020
@fullofcaffeine fullofcaffeine force-pushed the add/gb-upgrade-fill-in-blocks-image-galleriesish branch 2 times, most recently from 0e13f9b to 6c6bfaa Compare October 6, 2020 20:43
@fullofcaffeine
Copy link
Contributor Author

@bsessions85 Can you have a look? All tests are passing for this one.

WunderBart
WunderBart approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@WunderBart WunderBart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! No blockers here, so let's address the comments in a follow-up PR.

@WunderBart WunderBart added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 7, 2020
@bsessions85
Copy link
Contributor

I am fine with what @WunderBart said. looks good!

@fullofcaffeine
Setup and fill-in the Slidehow and Gallery Masonry block with sample …
33bf1b5 
…images

Cleaned up the Tiled Gallery's class a bit.
@fullofcaffeine fullofcaffeine force-pushed the add/gb-upgrade-fill-in-blocks-image-galleriesish branch from 6c6bfaa to 33bf1b5 Compare October 7, 2020 22:42
@fullofcaffeine fullofcaffeine added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Oct 7, 2020
@fullofcaffeine fullofcaffeine merged commit be1e4a8 into master Oct 7, 2020
@fullofcaffeine fullofcaffeine deleted the add/gb-upgrade-fill-in-blocks-image-galleriesish branch October 7, 2020 23:29
@WunderBart WunderBart mentioned this pull request Oct 8, 2020
Merged
@WunderBart
Copy link
Member

Follow-up PR: #46275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WunderBart WunderBart WunderBart approved these changes

@bsessions85 bsessions85 Awaiting requested review from bsessions85

@brbrr brbrr Awaiting requested review from brbrr

Assignees

@fullofcaffeine fullofcaffeine

Labels
[Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fullofcaffeine @matticbot @bsessions85 @WunderBart