Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg Upgrade E2E tweaks #46275

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Gutenberg Upgrade E2E tweaks #46275

merged 5 commits into from
Oct 13, 2020

Conversation

WunderBart
Copy link
Member

@WunderBart WunderBart commented Oct 8, 2020 •
edited
Loading

Changes proposed in this Pull Request

Addressing comments from #45797, #45798, and #45799.

Testing instructions

All the tests should pass.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=refactor/gb-upgrade-e2e-tweaks

@WunderBart WunderBart self-assigned this Oct 8, 2020
@WunderBart WunderBart added the [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot label Oct 8, 2020
@WunderBart WunderBart force-pushed the refactor/gb-upgrade-e2e-tweaks branch from afd5a02 to add3ce1 Compare October 8, 2020 14:24
This was referenced Oct 8, 2020
Merged
Merged
Merged
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@WunderBart WunderBart force-pushed the refactor/gb-upgrade-e2e-tweaks branch from add3ce1 to cd8937a Compare October 9, 2020 15:55
@WunderBart WunderBart force-pushed the refactor/gb-upgrade-e2e-tweaks branch from 9e98488 to 5aa11e0 Compare October 9, 2020 16:00
@WunderBart
Go back and use sendKeys directly
2f979b9 
The "setWhenSettable" helper doesn't work with hidden inputs.
@WunderBart WunderBart requested a review from a team October 12, 2020 13:34
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 12, 2020
@WunderBart WunderBart changed the title [WiP] Gutenberg Upgrade E2E tweaks Gutenberg Upgrade E2E tweaks Oct 12, 2020
sirreal
sirreal approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense and tests are passing as expected 👍

Thanks!

@WunderBart WunderBart merged commit 506258f into master Oct 13, 2020
@WunderBart WunderBart deleted the refactor/gb-upgrade-e2e-tweaks branch October 13, 2020 11:03
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

Assignees

@WunderBart WunderBart

Labels
[Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WunderBart @matticbot @sirreal