Editor Toolkit: update slide copy in NUX #46674

ramonjd · 2020-10-22T09:10:47Z

Changes proposed in this Pull Request

Updating copy to emphasis the hidden nature of new sites rather than the private by default aspect, which we'll be rolling back with coming soon v2 (by default new sites will be in coming soon mode, but public (not indexable)

We're also showing all steps now that the Launch button is persisting in p9Jlb4-1SN-p2 and #46817

Context p1603330128417000-slack-C9EJ7KSGH

Testing instructions

The quick and dirty way of checking the changes is to comment out the following lines in wpcom-nux.js

/*	
       if ( ! isWpcomNuxEnabled || isSPTOpen ) {
		return null;
	}
*/

Run yarn dev --sync from apps/editing-toolkit

Create a new site via /new

Sandbox that site

Navigate through the NUX modal to the last panel

Check that the copy reflect the changes in this PR

Also check that we're dislaying all the Nux Pages we return in getWpcomNuxPages()

matticbot · 2020-10-22T09:10:48Z

Test live: https://calypso.live/?branch=update/gutenboarding-nux-copy

matticbot · 2020-10-22T09:20:44Z

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D51631-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

matticbot · 2020-10-22T09:24:22Z

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/wpcom-nux.js

autumnfjeld

Copy updates confirmed! 👍🏼

a8ci18n · 2020-10-27T04:17:09Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5050272

Thank you @ramonjd for including a screenshot in the description! This is really helpful for our translators.

ramonjd · 2020-10-28T23:22:20Z

Requesting review again since the copy and slide count have changed 🙇

a8ci18n · 2020-10-28T23:26:40Z

apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/wpcom-nux.js

@@ -108,17 +106,15 @@ function getWpcomNuxPages( isGutenboarding ) {
 			alignBottom: true,
 		},
 		{
-			heading: __( 'Private until you’re ready', 'full-site-editing' ),
+			heading: __( 'Hidden until you’re ready', 'full-site-editing' ),


⚠️ This change will be queued for retranslation. We'll display the English text until then.

a8ci18n · 2020-10-29T00:28:31Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5050272

Thank you @ramonjd for including a screenshot in the description! This is really helpful for our translators.

p-jackson

Click “Launch” in the toolbar to share it with the world.

Last I knew the button said "Complete setup" but maybe that's changed now?

I seem to be doing something wrong because for some reason I'm not seeing any gutenboarding button in the toolbar at all ...

p-jackson · 2020-10-29T03:50:39Z

apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/wpcom-nux.js

-			// @TODO: hide for sites that are already public
-			shouldHide: ! isGutenboarding,


Technically thie @TODO hasn't been addressed, but I don't know who's responsibility it is or even when this modal would appear for a public site so 🤷

My inclination is to let the reference to "hidden" slide for now. The main reason we're showing this one for all users I think stems from p9Jlb4-1SN-p2

The intention the button will now be displayed to users regardless of their path into WordPress and will be combined with the Focused launch flow work currently in development by Team Luna.

I'd leave the @T0D0 or create an issue for this because from what I understand it is referring to the launched/un-launched status of a website and not to the onboarding (site creation) flow. So here is an example where we probably don't want the slide to be displayed:

User created a site and landed in My Home or Plans (after abandoning cart).

User launched the site via Site setup checklist in My Home without opening the editor.

User navigates to the editor and the Launch button in the toolbar is gone since the site is already launched.

p-jackson · 2020-10-29T04:03:49Z

Yes just confirmed, the launch button only appears in the editor when I'm un-sandboxed or when I haven't run yarn dev --sync. If I use this branch for the ETK then the launch button isn't there!

Is the launch button broken on master? 🙀

ramonjd · 2020-10-29T04:05:43Z

Last I knew the button said "Complete setup" but maybe that's changed now?

Thanks for asking @p-jackson !

p9Jlb4-1SN-p2 says

Persistent ‘Launch’ button displayed in the editor toolbar for both new and existing users
Re-label the button to read ‘Complete setup’ ‘Launch’

Not sure either! cc @ollierozdarz

I seem to be doing something wrong because for some reason I'm not seeing any gutenboarding button in the toolbar at all ...

Maybe we're waiting on #46817? is that right @ciampo ?

ollierozdarz · 2020-10-29T04:08:22Z

Last I knew the button said "Complete setup" but maybe that's changed now?

Thanks for asking @p-jackson !

p9Jlb4-1SN-p2 says

Persistent ‘Launch’ button displayed in the editor toolbar for both new and existing users
Re-label the button to read ‘Complete setup’ ‘Launch’

Not sure either! cc @ollierozdarz

@ramonjd the button currently says 'Complete setup' for users who came through Gutenboarding, however we've planned to change the lablel to say 'Launch' with the new persistent launch button work.

p-jackson · 2020-10-29T04:08:28Z

@ramonjd ok I've confirmed that the launch button works on the latest master, but was broken on the version of master that you started your PR on (205c3bd)

So you could rebase if you wanted to confirm, but yes it looks like the launch button is all good now.

ramonjd · 2020-10-29T04:16:54Z

@ramonjd ok I've confirmed that the launch button works on the latest master, but was broken on the version of master that you started your PR on (205c3bd)

Very grateful for your investigations!

…he private by default aspect, which we'll be rolling back with coming soon v2 (by default new sites will be in coming soon mode, but public (not indexable)

Updating copy to remove reference to coming soon and highlight the launch button

Showing all steps now. No filtering of nux pages.

ciampo · 2020-10-29T08:23:54Z

Maybe we're waiting on #46817? is that right @ciampo ?

Hey @ramonjd and @p-jackson! The gutenboarding/persistent-launch-button flag is only enabled in development at the moment. Without that feature flag, the "Launch" button is only shown for sites created with Gutenboarding.

For more context, you can refer to #46558 (introduction of the persistent launch button behind a flag, merged) and #46817 (enabling the feature flag for all environments, waiting to be merged)

(cc @razvanpapadopol )

razvanpapadopol · 2020-10-29T09:20:15Z

What @ciampo wrote above plus one note:

@ramonjd the button currently says 'Complete setup' for users who came through Gutenboarding, however we've planned to change the lablel to say 'Launch' with the new persistent launch button work.

We already replaced 'Complete setup' label with 'Launch' also for Gutenboarding in #46558 so at this moment we should just wait for strings to be translated and then merge this PR and #46817 🚢

ramonjd · 2020-10-29T22:18:35Z

We already replaced 'Complete setup' label with 'Launch' also for Gutenboarding in #46558 so at this moment we should just wait for strings to be translated and then merge this PR and #46817 🚢

Thanks for the info @razvanpapadopol and @ciampo! All good, ~~I'll put a string freeze on this PR and keep it on ice~~ :) thanks for adding the string freeze 😇

a8ci18n · 2020-11-06T12:28:30Z

Translation for this Pull Request has now been finished.

ramonjd added [Goal] New Onboarding previously called Gutenboarding Coming Soon labels Oct 22, 2020

ramonjd requested a review from a team October 22, 2020 09:12

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 22, 2020

ramonjd assigned ramonjd and unassigned ramonjd Oct 22, 2020

a8ci18n reviewed Oct 22, 2020

View reviewed changes

apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/wpcom-nux.js Outdated Show resolved Hide resolved

ramonjd requested a review from autumnfjeld October 23, 2020 00:20

autumnfjeld self-assigned this Oct 27, 2020

autumnfjeld approved these changes Oct 27, 2020

View reviewed changes

ramonjd added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 27, 2020

razvanpapadopol mentioned this pull request Oct 28, 2020

Persistent Launch Button: enable in all environments #46817

Merged

ramonjd requested a review from ollierozdarz October 28, 2020 23:04

ramonjd removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 28, 2020

ramonjd requested a review from autumnfjeld October 28, 2020 23:21

a8ci18n reviewed Oct 28, 2020

View reviewed changes

p-jackson reviewed Oct 29, 2020

View reviewed changes

ramonjd and others added 2 commits October 29, 2020 15:17

Updating copy to emphasis the hidden nature of Coming Soon, but not t…

24b107f

…he private by default aspect, which we'll be rolling back with coming soon v2 (by default new sites will be in coming soon mode, but public (not indexable)

Update wpcom-nux.js

fde7cb5

Updating copy to remove reference to coming soon and highlight the launch button

Update wpcom-nux.js

5f7dda4

Showing all steps now. No filtering of nux pages.

ramonjd force-pushed the update/gutenboarding-nux-copy branch from a3ec07e to 5f7dda4 Compare October 29, 2020 04:19

razvanpapadopol added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 29, 2020

ciampo merged commit 6a9bbcc into master Nov 6, 2020

ciampo deleted the update/gutenboarding-nux-copy branch November 6, 2020 12:03

matticbot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Nov 6, 2020

ciampo mentioned this pull request Nov 6, 2020

Editing Toolkit: Update to 2.8.4 #47186

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Editor Toolkit: update slide copy in NUX #46674

Editor Toolkit: update slide copy in NUX #46674

ramonjd commented Oct 22, 2020 •

edited

Loading

matticbot commented Oct 22, 2020

matticbot commented Oct 22, 2020

matticbot commented Oct 22, 2020

autumnfjeld left a comment

a8ci18n commented Oct 27, 2020

ramonjd commented Oct 28, 2020

a8ci18n Oct 28, 2020

a8ci18n commented Oct 29, 2020 •

edited

Loading

p-jackson left a comment

p-jackson Oct 29, 2020

ramonjd Oct 29, 2020

razvanpapadopol Nov 6, 2020 •

edited

Loading

p-jackson commented Oct 29, 2020

ramonjd commented Oct 29, 2020

ollierozdarz commented Oct 29, 2020

p-jackson commented Oct 29, 2020

ramonjd commented Oct 29, 2020

ciampo commented Oct 29, 2020

razvanpapadopol commented Oct 29, 2020 •

edited

Loading

ramonjd commented Oct 29, 2020 •

edited

Loading

a8ci18n commented Nov 6, 2020

		// @TODO: hide for sites that are already public
		shouldHide: ! isGutenboarding,

Editor Toolkit: update slide copy in NUX #46674

Editor Toolkit: update slide copy in NUX #46674

Conversation

ramonjd commented Oct 22, 2020 • edited Loading

Changes proposed in this Pull Request

Testing instructions

matticbot commented Oct 22, 2020

matticbot commented Oct 22, 2020

matticbot commented Oct 22, 2020

autumnfjeld left a comment

Choose a reason for hiding this comment

a8ci18n commented Oct 27, 2020

ramonjd commented Oct 28, 2020

a8ci18n Oct 28, 2020

Choose a reason for hiding this comment

a8ci18n commented Oct 29, 2020 • edited Loading

p-jackson left a comment

Choose a reason for hiding this comment

p-jackson Oct 29, 2020

Choose a reason for hiding this comment

ramonjd Oct 29, 2020

Choose a reason for hiding this comment

razvanpapadopol Nov 6, 2020 • edited Loading

Choose a reason for hiding this comment

p-jackson commented Oct 29, 2020

ramonjd commented Oct 29, 2020

ollierozdarz commented Oct 29, 2020

p-jackson commented Oct 29, 2020

ramonjd commented Oct 29, 2020

ciampo commented Oct 29, 2020

razvanpapadopol commented Oct 29, 2020 • edited Loading

ramonjd commented Oct 29, 2020 • edited Loading

a8ci18n commented Nov 6, 2020

ramonjd commented Oct 22, 2020 •

edited

Loading

a8ci18n commented Oct 29, 2020 •

edited

Loading

razvanpapadopol Nov 6, 2020 •

edited

Loading

razvanpapadopol commented Oct 29, 2020 •

edited

Loading

ramonjd commented Oct 29, 2020 •

edited

Loading