Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Toolkit: Update to 2.8.4 #47186

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Editing Toolkit: Update to 2.8.4 #47186

merged 1 commit into from
Nov 9, 2020

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Nov 6, 2020

Changes proposed in this Pull Request

  • Version bump and changelog

Changes to Editing Toolkit since 2.8.3:

Testing instructions

  1. Load the diff on your sandbox D52369-code and confirm that the above changes work correctly

  2. Test that the new version of the plugin doesn't break Atomic sites by following the instructions in the "Atomic Testing" section at PCYsg-ly5-p2.

@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2020
@ciampo ciampo requested a review from deBhal November 6, 2020 12:27
@ciampo ciampo added the Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin label Nov 6, 2020
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52369-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ciampo
Copy link
Contributor Author

ciampo commented Nov 6, 2020

It looks like the text in the last slide of the editor welcome modal is not translated correctly:

Screenshot 2020-11-06 at 15 39 32

See p1604665886075900-slack-C014TPFLP for more details.

We should:

  • wait for Editor NUX modal: Temporarily make text smaller in editor welcome modal for german language #47193 to be merged merged
  • wait for the translations to be picked up apparently, in order for translations to appear, we need to release the plugin to .org first — which means that potentially some user will see the untranslated text
  • rebase on top of master, and update this PR to include all of the changes that were committed to Editing Toolkit in the meantime no changes to apps/editing-toolkit since last rebase
  • re-test changes and deploy

@autumnfjeld
Copy link
Contributor

Verified:
✅ Add recordTracksEvent for Editor NUX modal (#46796) : track events are firing and sending network request

@ciampo
Copy link
Contributor Author

ciampo commented Nov 9, 2020

D52369-code deployed, 2.8.4 released to dotorg. I'm going to merge this PR too

The failing phpunit test is caused by a mismatch in the node version — see p1604598992424000-slack-C02DQP0FP

@ciampo ciampo assigned ciampo and unassigned ciampo Nov 9, 2020
@ciampo ciampo merged commit 1072b7b into master Nov 9, 2020
@ciampo ciampo deleted the update/edt-2.8.4 branch November 9, 2020 11:02
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Status] Blocked / Hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants