-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make text of Premium Content's Subscribe button editable #46983
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52108-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
There was a hook configured to reset the text of the Subscribe button back to 'Subscribe' each time it is updated, which makes it impossible to edit the text. This commit removes that hook.
134af2e
to
2c8650e
Compare
Provides a jetpack/button block within the inner blocks template for the recurring payments block used by premium content. Also includes eslint formatting fix and addition of missing dependency in hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, went through testing instructions and confirmed I could change the button text. It stuck after publishing and refreshing the editor.
Changes proposed in this Pull Request
The Premium Content block's 'Subscribe' button text could not be edited; it reverts instantly back to 'Subscribe'. There was a hook configured to reset the text each time the component was updated. This PR removes that. There is also an update to the block to correctly initialize the button text to 'Subscribe' the first time it is added.
Testing instructions
Fixes #46347