Make text of Premium Content's Subscribe button editable #46983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52108-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
There was a hook configured to reset the text of the Subscribe button back to 'Subscribe' each time it is updated, which makes it impossible to edit the text. This commit removes that hook.
stacimc
force-pushed
the
update/editable-subscribe-button-text
branch
from
134af2e
to
2c8650e
Compare
Provides a jetpack/button block within the inner blocks template for the recurring payments block used by premium content. Also includes eslint formatting fix and addition of missing dependency in hook.
matticbot
added
the
[Status] Needs Review
apeatling
added
the
Premium Content
apeatling
approved these changes
Nov 5, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
The Premium Content block's 'Subscribe' button text could not be edited; it reverts instantly back to 'Subscribe'. There was a hook configured to reset the text each time the component was updated. This PR removes that. There is also an update to the block to correctly initialize the button text to 'Subscribe' the first time it is added.
Testing instructions
Fixes #46347