-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coming Soon: updating the fallback page #46994
Conversation
…svg for the wp logo For the site badges: only show the coming soon v2 badge if the site is not private (to avoid showing two badges while we're testing v2)
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52126-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~224 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~20 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on atomic and simple sites and this fixes the image issue and the duplicate coming soon issue is fixed too 👍 🚢
I also noticed, that we don't have the "marketting bar" on atomic sites, the one that says "Create your website at wordpress.com". But this fix is good!
Changes proposed in this Pull Request
This PR swaps the WP logo image with the relative path so it will display on all sites (think Atomic), and namespaces the class names.
We're also removing the test copy for v2. We can tell v2 from v1 by the class names in the source.
As an aside, I also noticed the appearance of two coming soon badges on the site bar. This will happen hopefully only during testing, when you're toggling coming soon v2 on an existing site, but I added a small safeguard to prevent that.
Testing instructions
While sandboxing, run
yarn dev --sync
inapps/editing-toolkit
Create a new site over at wordpress.com/new?flags=coming-soon-v2
Take a look at the new site in an incognito window. You should see the coming soon page (the class names should be prefixed with
wpcom-coming-soon-*
and the WordPress logo should be an SVG)On an existing test site (or one created at wordpress.com/new), make sure you have coming soon enabled. The go to the settings page with the flag enabled, e.g.,
http://calypso.localhost:3000/settings/general/your_test_site?flags=coming-soon-v2
.You should only see one badge.