Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premium Content: Remove premium content block placeholder #47068

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

apeatling
Copy link
Member

Changes proposed in this Pull Request

Do not use a placeholder when the user is not on the required plan. Allow them to see and edit content. This will allow patterns to render for folks without a plan.

This PR should be merged along with Automattic/jetpack#17702 to allow the payments block to be interacted with without a plan.

Before
Only showing placeholder:

Screen Shot 2020-11-03 at 12 03 59 PM

After
Showing editable content:

Screen Shot 2020-11-03 at 12 04 18 PM

Testing instructions

Fixes https://github.com/Automattic/view-design/issues/124

@apeatling apeatling added [Type] Enhancement Premium Content Controlling specific content for paying site visitors. labels Nov 3, 2020
@apeatling apeatling requested a review from a team November 3, 2020 20:07
@apeatling apeatling self-assigned this Nov 3, 2020
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 3, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52241-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that the Premium Content block loads with editable content on a free plan, but does not display on the frontend. I still see the jetpack recurring payments disclaimer, which is causing some odd styling, but it looks like that will be removed with the jetpack PR you linked -- so looks good to me.

Approving because I think this is intended, but I did have a question: The upgrade banner only displays when the top-level Premium Content block is selected (meaning if you click out of the block or into an inner block, it disappears and the warning is no longer visible). I think this is expected behavior for upgrade banners, but just calling out as a potential source of confusion.

@apeatling apeatling merged commit 25a504b into master Nov 5, 2020
@apeatling apeatling deleted the remove/premium-content-placeholder branch November 5, 2020 21:34
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Premium Content Controlling specific content for paying site visitors. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants