Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused vars from global styles font pairings #47072

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Nov 3, 2020

Changes proposed in this Pull Request

Testing instructions

I re-ran through the testing from the original PR, which was updating global font styles:

Check out the branch and sync to your sandbox using yarn dev --sync
Create a new post and open the Global Styles editor.

  • Verify that the five font pairings displayed match what is listed in the spreadsheet
  • Verify that the UI has been updated to match Gutenboarding
  • Select a new font pairing and verify that the text in the post updates
  • Select 'Publish' in the global styles sidebar and verify that the new font selection persists when the page is refreshed
  • Select a different heading or base font from the Font Selection panel and verify that the selection (blue outline) is removed from the Font Pairings window
  • Manually select a font pairing by making the Heading and Base font selections from the Font Selection window (eg manually select "Cabin" and "Raleway" from the dropdowns) and verify that the matching font pairing is selected in the UI (eg, the blue outline appears around "Cabin / Raleway")

@stacimc stacimc requested review from oandregal and a team as code owners November 3, 2020 21:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 3, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52244-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested fine for me, global styles still display and work as expected with these changes applied.

@stacimc stacimc merged commit d6077e9 into master Nov 3, 2020
@stacimc stacimc deleted the fix/remove-unused-vars-in-global-styles branch November 3, 2020 21:41
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants