Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor NUX modal: Temporarily make text smaller in editor welcome modal for german language #47193

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Editor NUX modal: Temporarily make text smaller in editor welcome modal for german language #47193

merged 2 commits into from
Nov 6, 2020

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Nov 6, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • Smaller font size for heading in NUX modal when locale is German
  • This is to avoid text clipping

Testing instructions

Before

Screenshot 2020-11-06 at 15 39 21

After

Screenshot 2020-11-06 at 17 45 27

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/editor-welcome-hotfix-font-size

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2020
@ciampo ciampo changed the title Editor NUX modal: @ciampo Temporarily make text smaller in editor welcome modal for german language Editor NUX modal: Temporarily make text smaller in editor welcome modal for german language Nov 6, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52381-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@ciampo ciampo added Coming Soon and removed NUX labels Nov 6, 2020
@ciampo ciampo self-assigned this Nov 6, 2020
@ciampo ciampo mentioned this pull request Nov 6, 2020
Open
@ciampo
Copy link
Contributor Author

ciampo commented Nov 6, 2020

In the meantime, Opened #47195 to report the issue

@ciampo ciampo mentioned this pull request Nov 6, 2020
Merged
tjcafferkey
tjcafferkey approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this works, although the last step is still in English but AFAIK we are already aware of this.

Thanks also for creating a new issue to report & keep track of the original bug so we don't have to live with hacky fixes forever 👍🏻

nux

@ciampo ciampo merged commit 9692be7 into master Nov 6, 2020
@ciampo ciampo deleted the fix/editor-welcome-hotfix-font-size branch November 6, 2020 20:31
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjcafferkey tjcafferkey tjcafferkey approved these changes

@razvanpapadopol razvanpapadopol Awaiting requested review from razvanpapadopol

@ramonjd ramonjd Awaiting requested review from ramonjd

@autumnfjeld autumnfjeld Awaiting requested review from autumnfjeld

Assignees

@ciampo ciampo

Labels
Coming Soon [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciampo @matticbot @tjcafferkey