Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/lint md files #47453

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Fix/lint md files #47453

merged 3 commits into from
Nov 16, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Nov 16, 2020

Changes proposed in this Pull Request

  • Apply eslint fixes to MD files
  • Configure exceptions for code blocks inside MD files

Testing instructions

  • N/A

@scinos scinos requested review from a team as code owners November 16, 2020 10:49
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/lint-md-files

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 16, 2020
@scinos scinos requested a review from a team November 16, 2020 10:49
@scinos scinos self-assigned this Nov 16, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos added the Code Style Changes related to eslint rules label Nov 16, 2020
tyxla
tyxla approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍 LGTM 🚢

I've added a couple of non-blocking suggestions which you could address to please ESLint if you wish.

packages/data-stores/README.md Show resolved Hide resolved
packages/data-stores/README.md Show resolved Hide resolved
@scinos scinos merged commit 6ad695d into master Nov 16, 2020
@scinos scinos deleted the fix/lint-md-files branch November 16, 2020 13:34
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 16, 2020
@sirbrillig sirbrillig mentioned this pull request Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees

@scinos scinos

Labels
Code Style Changes related to eslint rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scinos @matticbot @tyxla