Analytics: Fix recordTracksEvent import in analytics library docs

[sirbrillig]

Changes proposed in this Pull Request

There are two ways to call recordTracksEvent(); one is by using the function directly from the @automattic/calypso-analytics package, and the other is to use the calypso data-layer middleware by dispatching an action to redux. This is a little confusing because both the raw function and the redux action creator are called recordTracksEvents, but they are defined in two different places.

In #41125, an example was added to the README of the @automattic/calypso-analytics package to explain how to use the redux action creator rather than the raw function, but #47453 (accidentally, I think) broke that example. Using the code in the example will in fact throw an error since the exported recordTracksEvents function has no return value and cannot be used as an action creator. This PR restores the correct example, which is not ideal because it references an import path in a separate npm package, but it is better than providing an example that is totally wrong.

Testing instructions

None needed. Just verify that places that use recordTracksEvents inside a redux dispatch call are importing from the location in the corrected example.

Eg:

wp-calypso/client/my-sites/checkout/composite-checkout/hooks/use-create-payment-complete-callback.tsx

Line 40 in 76f435d

import { recordTracksEvent } from 'calypso/state/analytics/actions';

[matticbot]

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-7610
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-7610&env=jetpack

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[ramonjd]

I performed a smoke test of a dozen or so places where we're calling dispatch( recordTracksEvent( ... ) );

In all instances, we're importing recordTracksEvent from

import { recordTracksEvent } from 'calypso/state/analytics/actions';