-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Add analytics to the purchase confirm cancellation submit button #480
Conversation
QA 👍 |
0180940
to
529f254
Compare
@@ -66,6 +67,12 @@ const ConfirmCancelPurchase = React.createClass( { | |||
} | |||
|
|||
notices.success( response.message, { persistent: true } ); | |||
|
|||
analytics.tracks.recordEvent( | |||
'calypso_purchases_submit_cancel_form', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor, but I believe this should be calypso_purchases_cancel_form_submit
per the analytics readme:
In order to keep similar events grouped together when output in an alphabetized list (as is typical with ananlytics tools), put the verb at the end of the event name
20c604e
to
9bc5325
Compare
I updated your commit to use LGTM. |
9bc5325
to
9e7b532
Compare
…onfirmation Purchases: Add analytics to the purchase confirm cancellation submit button
Adds a
calypso_purchases_submit_cancel_form
event to the submit button form the cancel confirmation page.Fixes #271 (part of it)
Testing
git checkout add/analytics-submit-cancel-confirmation
calypso:analytics
to the debugger so you see analytics calls in your consolecalypso_purchases_submit_cancel_form
with theproduct_slug
property