Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Add a submit event to tracks when the user saves their credit card details #484

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Purchases: Add a submit event to tracks when the user saves their credit card details #484

merged 1 commit into from
Nov 24, 2015

Conversation

scruffian
Copy link
Member

Adds a calypso_purchases_submit_credit_card_form event to the submit button form the cancel confirmation page.

Fixes #271 (part of it)

Testing

  1. git checkout add/purchases-analytics-edit-card-details
  2. Open http://calypso.dev:3000/purchases
  3. Add calypso:analytics to the debugger so you see analytics calls in your console
  4. Open a purchase and go to the edit payment details page
  5. Enter card details and submit the form
  6. Assert that you see this event: calypso_purchases_submit_credit_card_form with the product_slug property
  • Code review
  • QA review

@scruffian scruffian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 23, 2015
@scruffian scruffian self-assigned this Nov 23, 2015
@scruffian scruffian added this to the Purchases: v1 milestone Nov 23, 2015
@scruffian scruffian changed the title Purchases: Add a submit event to tracks when the user saves their cre… Purchases: Add a submit event to tracks when the user saves their credit card details Nov 23, 2015
@scruffian scruffian mentioned this pull request Nov 23, 2015
Closed
13 tasks
@scruffian scruffian force-pushed the add/purchases-analytics-edit-card-details branch from ea44d1d to 0c6d7cb Compare November 23, 2015 17:16
@fabianapsimoes
Copy link
Contributor

QA 👍

@drewblaisdell drewblaisdell force-pushed the add/purchases-analytics-edit-card-details branch from 0c6d7cb to c32a39c Compare November 24, 2015 00:00
@drewblaisdell
Copy link
Contributor

I updated your commit to use getPurchase and follow the Tracks naming conventions from the analytics readme (the same changes I made in #480). If you're cool with that, this LGTM.

@drewblaisdell drewblaisdell added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 24, 2015
@scruffian scruffian force-pushed the add/purchases-analytics-edit-card-details branch from c32a39c to af340e6 Compare November 24, 2015 10:01
scruffian added a commit that referenced this pull request Nov 24, 2015
@scruffian
Merge pull request #484 from Automattic/add/purchases-analytics-edit-…
9a0ed03 
…card-details

Purchases: Add a submit event to tracks when the user saves their credit card details
@scruffian scruffian merged commit 9a0ed03 into master Nov 24, 2015
@scruffian scruffian deleted the add/purchases-analytics-edit-card-details branch November 24, 2015 10:12
@scruffian scruffian removed their assignment Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scruffian @fabianapsimoes @drewblaisdell