State: Move followers to redux #5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roccotripaldi
added
[Status] Needs Review
roccotripaldi
force-pushed
the
move-people-data-to-redux
branch
from
9e24f8e to
dc2c905
Compare
|
This may need a rebase, I'm seeing a lot of persistent redux schema errors in the browser console. Otherwise the included tests are working for me 👍 |
| export const FOLLOWER_REMOVE_REQUEST = 'FOLLOWER_REMOVE_REQUEST'; | ||
| export const FOLLOWER_REMOVE_ERROR = 'FOLLOWER_REMOVE_ERROR'; | ||
| export const FOLLOWER_REMOVE_SUCCESS = 'FOLLOWER_REMOVE_SUCCESS'; | ||
| export const FOLLOWERS_RECEIVE = 'FOLLOWERS_REQUEST_RECEIVE'; |
There was a problem hiding this comment.
Should this be:
-export const FOLLOWERS_RECEIVE = 'FOLLOWERS_REQUEST_RECEIVE';
+export const FOLLOWERS_REQUEST_RECEIVE = 'FOLLOWERS_REQUEST_RECEIVE';
roccotripaldi
force-pushed
the
move-people-data-to-redux
branch
from
dc2c905 to
c94e13c
Compare
|
Thanks for the review @jordwest ! I pushed a commit to address your helpful feedback. |
| removeFollower( siteId, follower ) { | ||
| return ( dispatch ) => { | ||
| debug( 'removing follower', follower, siteId ); | ||
| // TODO: replace REMOVE_FOLLOWER with FOLLOWER_REMOVE |
There was a problem hiding this comment.
Looks like this TODO can also be removed
|
Looks good! 🚢 |
jordwest
added
[Status] Ready to Merge
and removed
[Status] Needs Review
roccotripaldi
force-pushed
the
move-people-data-to-redux
branch
from
3d843f6 to
836aa88
Compare
This PR creates a folder in 'client/state' which will eventually replace the Flux implementation in 'client/lib/followers' with a Redux implementation. The Redux data is not yet being used anywhere; that will happen in an other PR that implements a `queryFollowers` component. I wrote a few tests, mostly to help ensure that the data is being properly stored in the tree.
`queries` will now contain `ids`, `total`, and `lastPage` as opposed to having separate closures for `total` and `lastPage`. This makes it easier to update totals when a follower is removed from the site.
Addressing feedback from @jordwest - improve syntax, remove TODOs
roccotripaldi
force-pushed
the
move-people-data-to-redux
branch
from
836aa88 to
4d01a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves followers to the redux state. See #5046
This PR creates a branch in the redux tree for followers. It does NOT yet make use of this data in any UI components. A separate PR will handle a
queryFollowerscomponent to replace the current Flux implementation.To test:
npm run testand ensure all follower tests are passingstate/followers/test/reducer.js,state/followers/test/selectors.js, andstate/followers/test/utils.jschange the top leveldescribe()todescribe.only()to run just the follower testsCheck for regressions
Because I made a small change to a WPCOM api method, ensure that removing people still works. Select a site, go to People, select a Team member or Follower, and ensure that you can remove them from the site.
cc: @ebinnion @lezama