Themes: Add current-theme query component #5361
Conversation
seear
added
[Feature Group] Appearance & Themes
Replaces the old-style fetcher component.
seear
force-pushed
the
add/query-current-theme
branch
from
85aa01e to
fcc292a
Compare
seear
added
[Status] Needs Review
|
The (visual) current theme component isn't updated for me when activating a theme on a Jetpack site, and even the thanks modal display's the previous theme's name :-( |
|
Actually, not just on Jetpack sites... |
| case THEME_ACTIVATE: | ||
| return state.set( 'isActivating', true ); | ||
| case THEME_ACTIVATED: | ||
| return state | ||
| .set( 'isActivating', false ) | ||
| .set( 'hasActivated', true ) | ||
| .setIn( [ 'currentThemes', action.site.ID ], action.theme ); | ||
| .setIn( [ 'currentThemes', action.siteId ], action.theme ); |
There was a problem hiding this comment.
@ockham: this is the problem—overzealous trimming of site usage. Fixing...
fixed in b2ba232 |
|
Loving it. Squash it, 🚢 it! Aside — Can we incorporate |
Yeah, was mulling that over myself, definite next step. Thanks for review :) |
matticbot
removed
the
[Status] Needs Review
Replaces the old-style fetcher component.
A query component to replace the old-style fetcher component. Will make it very easy to determine current theme properly in theme sheets (#5285)
No visual changes
To Test
Expected: the CURRENT THEME bar works as previously
Things to check:
localStorage.clear();in console then refresh