Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual page: Hide description and popover when the template is not able to resolve #71702

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jan 5, 2023

Proposed Changes

  • Now we're able to resolve the homepage template if the atomic site is private. So, this PR proposes to hide the description of the virtual homepage and change the copy of the popover.
Before After
image image

Testing Instructions

  • Go to /home/<your_atomic_site>
  • Go to Settings, and configure the Privacy to "private"
  • Go to Themes, and activate the themes whose "Your homepage displays" is configured to "Your latest posts", e.g.: TT3
  • Go to /pages

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #71375, #71541, Automattic/jetpack#28158

@arthur791004 arthur791004 self-assigned this Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@arthur791004 arthur791004 requested a review from a team January 5, 2023 09:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 5, 2023
@matticbot
Copy link
Contributor

matticbot commented Jan 5, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~115 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
pages       +548 B  (+0.1%)     +115 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before After
Screen Shot 2023-01-06 at 11 46 27 AM Screen Shot 2023-01-06 at 11 46 06 AM

} else if (
isEnglishLocale ||
hasTranslation(
'You can change the content of this page by editing the template using the Site Editor. {{learnMoreLink}}Learn more{{/learnMoreLink}}.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing by editing the template to cut the word count and to make it consistent with the non-admin case above, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@arthur791004 arthur791004 force-pushed the fix/virtual-home-page-on-atomic-site branch from 871ae13 to f3e0017 Compare January 6, 2023 07:23
@arthur791004 arthur791004 merged commit 18b786a into trunk Jan 6, 2023
@arthur791004 arthur791004 deleted the fix/virtual-home-page-on-atomic-site branch January 6, 2023 07:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 6, 2023
@a8ci18n
Copy link

a8ci18n commented Jan 6, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7712622

Thank you @arthur791004 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 12, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants