-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual page: Hide description and popover when the template is not able to resolve #71702
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~115 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else if ( | ||
isEnglishLocale || | ||
hasTranslation( | ||
'You can change the content of this page by editing the template using the Site Editor. {{learnMoreLink}}Learn more{{/learnMoreLink}}.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest removing by editing the template
to cut the word count and to make it consistent with the non-admin case above, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
871ae13
to
f3e0017
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7712622 Thank you @arthur791004 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Testing Instructions
/home/<your_atomic_site>
/pages
Pre-merge Checklist
Related to #71375, #71541, Automattic/jetpack#28158