Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(POC) Theme Showcase: Style selection in the theme details page #72906

Closed
wants to merge 2 commits into from

Conversation

taipeicoder
Copy link
Contributor

Proposed Changes

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #

@taipeicoder taipeicoder self-assigned this Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

@taipeicoder taipeicoder added [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. DO NOT MERGE labels Feb 2, 2023
@matticbot
Copy link
Contributor

matticbot commented Feb 2, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~89 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +492 B  (+0.0%)      +87 B  (+0.0%)
entry-main                  +492 B  (+0.0%)      +83 B  (+0.0%)
entry-login                 +384 B  (+0.0%)      +84 B  (+0.0%)
entry-domains-landing       +384 B  (+0.1%)      +84 B  (+0.1%)
entry-browsehappy           +384 B  (+0.4%)      +84 B  (+0.3%)
entry-gutenboarding         +371 B  (+0.0%)      +87 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4207 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
theme     +13141 B  (+2.7%)    +4207 B  (+2.9%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2261 bytes added 📈 [gzipped])

name                                                                 parsed_size           gzip_size
async-load-automattic-design-preview-src-components-style-variation   +1164747 B    (new)  +348886 B    (new)
async-load-automattic-design-preview                                      +618 B  (+0.1%)      +63 B  (+0.0%)
async-load-pattern-list-renderer                                           -13 B  (-0.0%)      +17 B  (+0.0%)
async-load-pattern-large-preview                                           -13 B  (-0.0%)      +15 B  (+0.0%)
async-load-pattern-assembler-container                                     -13 B  (-0.0%)      +19 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder
Copy link
Contributor Author

Closing in favor of #73277.

@taipeicoder taipeicoder deleted the feat/themes-details-page-style-selection branch February 20, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants