-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Showcase: Update the theme detail page layout #73277
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~54 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~3537 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~2261 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Hmmm, seems that the way the height is calculated is quite fragile 😅 I've adjusted its size to be smaller for the mobile view. This is intended to follow the same style in /plugins (e.g.: https://wordpress.com/plugins/woocommerce). Mentioned by @davewhitley in 0EogtxvlmxMGcnEEaMVECv-fi-2412%3A63031 and |
client/my-sites/theme/style.scss
Outdated
flex-basis: 120px; | ||
flex-shrink: 0; | ||
|
||
@include breakpoint-deprecated( "<960px" ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it should be 1024px
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed Changes
This PR updates the theme detail page layout as per the design spec in 0EogtxvlmxMGcnEEaMVECv-fi-2412%3A63031. In the spirit of controlling the scope of this PR, style variations and upsell banners will be continued to be worked on in later PRs. In other words, this PR is about the layout changes made to the theme detail page for both desktop and mobile views.
Desktop view
Mobile view
Testing Instructions
/themes/${site_slug}
. If using calypso.live, the flagthemes/showcase-i4/details-and-preview
is required.Note: There will be flash of old UI before the new UI is applied. This is due to the feature flag being activated with a delay, and so the flash of old UI won't happen once the feature flag is enabled by default.
Pre-merge Checklist