Sharing: Remove SharingConnectionsData component #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Post/Page Editor
|
I love all red PR's. I could not find any occurrences of |
timmyc
added
[Status] Ready to Merge
and removed
[Status] Needs Review
aduth
added a commit
that referenced
this pull request
Nov 25, 2015
Sharing: Remove SharingConnectionsData component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to remove the
<SharingConnectionsData />component. It was only ever used once, in the context of the post editor for managing connections data, though this has since been replaced with<EditorSharingContainer />in #338.Testing instructions:
Verify that I haven't missed any references to the component, and that the post editor continues to load and display Publicize connections in the Sharing sidebar accordion.