Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update sharing container to use selected site from Redux state #756

Merged
merged 2 commits into from
Dec 15, 2015

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Nov 25, 2015

Blocked by #751

This pull request seeks to make use of the new sites module introduced in #751 to eliminate the dependency on the sites-list site object passed to the <EditorSharingContainer /> component. It also includes the necessary wiring to ensure that the selected site is assigned in the My Sites selectedSite middleware function, and that the sites reducers are included in the global reducer.

Testing instructions:

Verify that post editor Publicize connections are accurate for the site visited, that no errors are shown in the developer tools console, and that Publicize connections update upon changing the selected site in the post editor.

  1. Navigate to the Calypso post editor
  2. Select a site, if prompted
  3. Note that the Sharing accordion displays with a loading indicator and is replaced with the set of Publicize connections available for that site (or blank if no Publicize connections)
  4. Change the selected site from the New Post button
  5. Note that the Publicize connections update to reflect the connections available for the newly selected site

@aduth aduth added [Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Status] In Progress labels Nov 25, 2015
@aduth aduth self-assigned this Nov 25, 2015
@jkudish
Copy link
Contributor

jkudish commented Nov 26, 2015

I discovered #867 while testing this, but it turned out to be in master too (probably happened from #338?)

Otherwise, this works and looks good to me, pending #751 of course.

@aduth aduth force-pushed the update/editor-sharing-sites-redux branch from 5009ac7 to 0f04495 Compare December 11, 2015 02:09
@aduth aduth added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 11, 2015
@aduth
Copy link
Contributor Author

aduth commented Dec 11, 2015

Rebased to account for #751, which was recently merged.

@@ -120,7 +120,7 @@ var EditorDrawer = React.createClass( {
}

return (
<EditorSharingContainer site={ this.props.site } currentUserID={ currentUser.ID } />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gwwar
Copy link
Contributor

gwwar commented Dec 14, 2015

Tested on Chrome, IE11, Edge. :shipit:

@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 14, 2015
@aduth aduth force-pushed the update/editor-sharing-sites-redux branch from 0f04495 to e69f170 Compare December 15, 2015 13:43
aduth added a commit that referenced this pull request Dec 15, 2015
…edux

Editor: Update sharing container to use selected site from Redux state
@aduth aduth merged commit 41e513b into master Dec 15, 2015
@aduth aduth deleted the update/editor-sharing-sites-redux branch December 15, 2015 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants