Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods in Theme Detail page #80129

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Aug 2, 2023

Related to

#79219
#79218

#34695
#9875
#5482

Proposed Changes

Cleaned up the ThemeSheet component a bit;

Screen Shot 2023-08-02 at 15 14 29

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3927 bytes removed 📉 [gzipped])

name   parsed_size           gzip_size
theme     -17398 B  (-2.8%)    -3927 B  (-2.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr changed the title Remove unused renderSectionNav Remove unused methods in Theme Detail page Aug 2, 2023
@okmttdhr okmttdhr marked this pull request as ready for review August 2, 2023 06:19
@okmttdhr okmttdhr requested review from jsnajdr, valterlorran, tyxla and a team August 2, 2023 06:20
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 2, 2023
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up!

@okmttdhr okmttdhr merged commit 10dcada into trunk Aug 2, 2023
@okmttdhr okmttdhr deleted the update/ThemeSheet branch August 2, 2023 07:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants