-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: Use 2year and 3year default interval type #96174
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~134 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~17009 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~4995 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
4450634
to
a0abfcc
Compare
This PR is on pause until further discussion about technical implementation is resolved in p9Jlb4-e5j-p2#comment-14161 |
a0abfcc
to
009f03e
Compare
const useLongerPlanTermDefaultExperiment = (): { | ||
isLoadingExperiment: boolean; | ||
term?: string | null; | ||
// TODO: Consider removing this and always return concrete term values (where undefined/null would mean no term savings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll study this a bit more. I want to make the "clean up" phase after the experiment as easy as possible, e.g., this hook remaining to define the default term/interval type.
@jeyip I think we are ready here to test. The experiment should be hooked to the logic. I still need to investigate something, but not blocking. |
Wonderful! Thanks for your work here @chriskmnds. Will review this tomorrow morning. |
...nt/my-sites/plans-features-main/hooks/experiments/use-longer-plan-term-default-experiment.ts
Show resolved
Hide resolved
@jeyip control variation should be fixed now, if we can give it another round of testing. I guess we can also ship this if it tests out right? concerning:
Shouldn't that be the case? i.e. show the savings if user is looking to upgrade from yearly to biennial (etc.)? 🤔 |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Yes will test again before I sign off today :) |
Oh man that's silly of me 🤦 For some reason, I thought I was on the same term view as the current plan ( annual current plan in the annual view ) and missed the biennial upgrade CTA. Yes you're right we should show savings in that case. |
I smoke tested the all treatments and the control again. Can confirm that everything works well now 🙂 |
isLoadingExperiment: isLoadingExperimentAssignment, | ||
term: isLoadingExperimentAssignment ? undefined : term, | ||
isEligibleForTermSavings: !! ( | ||
experimentAssignment?.variationName && experimentAssignment.variationName !== 'control' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if I'm missing something, but if variationName
returns null
for the control, do we still check if experimentAssignment.variationName !== 'control'
here?
Wouldn't just the experimentAssignment?.variationName
check be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still check if experimentAssignment.variationName !== 'control' here?
We don't (probably?). I kept it out of reaction for the most part. was a bit surprised how control
is treated as a non-entity/null
variation. Almost like a type-safe system is missing internally. I guess no harm in keeping the extra check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it out of reaction for the most part. was a bit surprised how control is treated as a non-entity/null variation.
Sounds good 🙂
021e5d8
to
67bd5de
Compare
3090e5f
to
32c9f83
Compare
Related to https://github.com/Automattic/martech/issues/3403
Branched from #96357 (term-savings logic)
Proposed Changes
Media
Why are these changes being made?
Low-tier, Personal and Premium Plan customers represent, by volume, the majority of dotcom plan purchases. With the Personal Plan alone, 45-50% of all users purchase said plan at signup. When considering monthly, yearly, 2 year, and 3 year billing terms, 35% of all users purchase an annual Personal Plan at signup.
Our low-tier users, however, are extremely price sensitive.
One potential way to address price sensitivity is to make our 2 year and 3 year plan discounts more prominent. By showing longer term plans on page load ( Ex. 2 year billing ), the plans grid monthly costs will render with 20% lower prices than with annual billing.
See pau2Xa-6wD-p2 for more context
Testing Instructions
/start/plans
and/plans/:site
. Confirm:Pre-merge Checklist