Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scroll bounce #56

Closed
wants to merge 1 commit into from
Closed

Conversation

artpi
Copy link

@artpi artpi commented Jan 27, 2016

What are you talking about?

OSX has natively this effect of 'bounce' when you are scrolling to the edge of current window.
I HATE THIS in the app.

Y u no CSS?

It is possible to achieve the same effect in CSS:

html.is-desktop {
overflow:hidden;
}
html.is-desktop body {
overflow: auto;
}

But this hides the scrollbar under masterbar and also messes with scrollbar visibility (the scrollbar disappers, but scrolling is still working)

Better solution

We discussed it with @rralian and decided that even better solution would be to play this video when while scrolling, we
push it to the limit / past the point of no return
Unfortunately, this clip is not GPL :/

Testing

Just scroll with swipe to the edge

CC @adambbecker @johngodley @dmsnell @gziolo

@johngodley
Copy link
Member

Apart from a missing semicolon on the preventDefault it looks good to me.

Pinging @jasmussen for thoughts.

@jasmussen
Copy link
Member

I also hate this rubberbanding scroll effect. I'm also glad you didn't go a CSS route, because we've already had issues tweaking the overflow. However I'm not convinced this should be an "app-only" thing, for a number of reasons.

Most importantly, every time we do a change that's app-only, we fragment our efforts between wp-calypso and wp-desktop, and actually cause technical debt we need to remember.

While there are many things we can and should do to make the app "feel" more native than it actually is, I feel like we're disregarding the legacy of the web, and the fact it's a web-app. For example on the web, clickable things have a hand cursor, in apps they have the default cursor. But this is not a native app, and any changes we make to pretend it is, I fear, will just cause confusion, and ultimately fragment the actual usability of this app compared to the web-app.

Bottomline is, on key areas like this I feel like the desktop app should mimic the web-app 1:1. And so if you'd like to disable the rubber banding effect, I feel like it should be done in an upstream wp-calypso PR, and not here. If you all strongly disagree with my assessment here, at the very least it should still be code that lives in Calypso and is then enabled in the desktop app through a feature flag.

@jasmussen
Copy link
Member

CC: @mtias

@artpi
Copy link
Author

artpi commented Jan 30, 2016

I am closing this PR.
Per @jasmussen advice, it is now in wp-calypso behing a featur flag: Automattic/wp-calypso#2929

@artpi artpi closed this Jan 30, 2016
@artpi artpi deleted the update/rubberband-scroll-disable branch January 30, 2016 22:14
@mtias
Copy link
Member

mtias commented Feb 1, 2016

@jasmussen sorry for the delay, I completely agree with your reasoning. My concern though is that hijacking the default OS behaviour may seem rather odd in a browser. Regardless, having this in wp-calypso anyways makes total sense, even if we enable it only for desktop via feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants