Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlTemplateResult has two members duplicating each other #10525

Closed
YohDeadfall opened this issue Mar 1, 2023 · 2 comments · Fixed by #11053
Closed

ControlTemplateResult has two members duplicating each other #10525

YohDeadfall opened this issue Mar 1, 2023 · 2 comments · Fixed by #11053
Assignees
Labels

Comments

@YohDeadfall
Copy link
Contributor

Describe the bug

ControlTemplateResult is made as an alias over its parent generic type. The parent type already has Result member of type Control in case of ControlTemplateResult, and ControlTemplateResult adds one more property named Control storing the same value.

Expected behavior

At least Control property must not have a backing field and use Result as the value source. Another option is to remove Control and leave the type mostly empty by using the base implementation.

@YohDeadfall YohDeadfall added the bug label Mar 1, 2023
@amwx
Copy link
Contributor

amwx commented Mar 1, 2023

I thought ControlTemplateResult was supposed to be removed and replaced as part of #6666 (first item which is checked off)

@kekekeks
Copy link
Member

I think it can be just removed, I don't see any critical usages.

grokys added a commit that referenced this issue Apr 18, 2023
Use `TempateResult<Control>` instead as described in #6666.

Fixes #10525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants