Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary compatibility cleanup list #6666

Closed
11 of 13 tasks
kekekeks opened this issue Oct 1, 2021 · 4 comments
Closed
11 of 13 tasks

Binary compatibility cleanup list #6666

kekekeks opened this issue Oct 1, 2021 · 4 comments
Assignees
Labels
Milestone

Comments

@kekekeks
Copy link
Member

kekekeks commented Oct 1, 2021

Since we are keeping binary compatibility with the latest nuget release, some design choices are sub-optimal in the long term.
This issue serves as a tracker for breaking changes that should be done during the preparation phase of the next version.

@grokys
Copy link
Member

grokys commented Dec 18, 2021

Currently AvaloniaLocator.GetService can return null if a service isn't found. This results in a lot of potential NREs. Should we change it to throw if the service is not found and add a TryGetService method?

@jp2masa
Copy link
Contributor

jp2masa commented Dec 18, 2021

For reference, Microsoft.Extensions.DependencyInjection has GetService and GetRequiredService for this purpose I believe: https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.dependencyinjection.serviceproviderserviceextensions?view=dotnet-plat-ext-6.0#methods.

(I'm personally not a fan of this pattern, but if you want to be consistent with official Microsoft packages I think this is relevant.)

@Takoooooo Takoooooo added this to the 11.0 milestone Feb 21, 2022
@danwalmsley
Copy link
Member

danwalmsley commented May 30, 2022

Remove ClientSize, Width / Height should be sufficient and we have FrameSize also.

@danwalmsley
Copy link
Member

Might as well put this here:
Provide windows ARM64 binaries for libgles etc. (all that is needed for just works arm on windows support)

@MikeCodesDotNET MikeCodesDotNET modified the milestone: 11.0 Nov 21, 2022
grokys added a commit that referenced this issue Apr 18, 2023
Use `TempateResult<Control>` instead as described in #6666.

Fixes #10525.
@danwalmsley danwalmsley changed the title Binary compatibility cleanup list Binary compatibility cleanup list (Transparency Hints) Apr 25, 2023
@grokys grokys self-assigned this May 26, 2023
@maxkatz6 maxkatz6 changed the title Binary compatibility cleanup list (Transparency Hints) Binary compatibility cleanup list May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants