[macOS][X11] Release mouse capture when dialog shown #16205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Jul 2, 2024
Comment on lines
+1327
to
+1328
| _mouse.PlatformCaptureLost(); | ||
| _touch.PlatformCaptureLost(); |
There was a problem hiding this comment.
Every day I am considering rewriting PointerDevice more and more. There are zero reasons to keep them separated.
maxkatz6
approved these changes
Jul 2, 2024
|
You can test this PR using the following package version. |
Gillibald
pushed a commit
to Gillibald/Avalonia
that referenced
this pull request
Jul 29, 2024
* Added integration test for AvaloniaUI#14525. * Release mouse capture when dialog shown. Fixes AvaloniaUI#14525. * Release X11 pointer capture when dialog shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #14525, mouse capture is released on Windows when a dialog is shown, but not on macOS. The issue doesn't mention it but we have the same problem on X11 too.
The fix for this is implemented in managed code. This is because:
XGrabPointercurrently, and theGrabNotifyevent which notifies of a pointer capture release isn't available on all X11 implementations anywayThe fix is implemented in
WindowImpl.SetEnabled(false)as this is the point on Windows whereWM_CANCELMODEis raised to inform us to release mouse capture: by doing it like this we match Windows' behavior.Also added an integration test.
Fixed issues
Fixes #14525