WIP: Use ItemsRepeater as base for ItemsPresenter #2 #4779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will be used/exposed on `IItemsPresenter` so will no longer be necessarily specific to `ItemsRepeater`.
Mostly working, although `Carousel` is currently non-functional.
Mark inline items (e.g. a `ListBoxItem` appearing directly in a `ListBox.Items` collection) as non-recyclable.
- Move interaction logic out of `SelectingItemsControl` - Don't select item when getting focus - Use ctrl+direction to move focus without changing selection - Bring focused control into view
`ItemsRepeater` should handle this for us (though doesn't always seem to get it right, due to a bug I think).
We need to make `ItemsSourceView` handle `IReadOnlyList<object>` as well as plain `IList`. This however exposed a problem where `CollectionChanged` events were still not getting to their handlers in the correct order, so did a bit of refactoring of `ItemsSourceView`.
Did not handle differing types.
Ensure necessary assemblies are loaded.
It throws. Also remove the key handling from `SelectingItemsControl` - it shouldn't handle interaction.
`Algorithm_GetAnchorForTargetElement` can return -1 and when it does so we try to realize that item, which obviously doesn't exist, so boom.
- Display number of realized containers - Allow switching between data templated items and inline `ListBoxItem`s
And update summary.
...when removed from source items.
To codify the usage of an `ItemsSourceView` in items presenters.
It's set when registering the items presenter.
And fix problems with reassigning `Items` that that showed up.
Make it slide horizontally and flip/resize vertically.
|
Closing: #2594 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
WIP on using
ItemsRepeateras the base forItemsPresenterto fix our janky virtualization.This is a long-term PR intended for some point between 0.10 and 0.11. Numerous breaking changes.
Fixes #2594