-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default namespace for F# item templates #160
Default namespace for F# item templates #160
Conversation
@Takoooooo Another thing I noticed for item templates namespace parameter is not clear. |
These two work normally for me. Both -na namespace and -p:n namespace. As i know these two parameters are just .NET CLI defaults which can be used independently so i think you don't need to change anything |
Not sure about this feature now because it takes like 30s to generate a simple item template when there is no solution or project where it can infer namespace from. Do you have any ideas how we can fix that @Mrxx99 ? |
@Takoooooo Is that a common use case to create an item template outside of a project? |
@Mrxx99 try creating an item template in just an empty folder,it takes like 30+s for me. Thats not a common use-case but i don't think it should take that long,even 11s thats too much IMO |
@Takoooooo I tried again in serveral random folder and could not reproduce it. It only happens for me inside the "avalonia-dotnet-templates" repo folder and it's subfolders . This also uses the same way the new class templates are added into the sdk (dotnet/sdk#29655) minus the option to also specify a manual namespace. |
In my pull request for default namespace for item templates (only C#) #154 I wrote that this approach only works for C#.
I was wrong, I just noticed that you will only get this result
when the project was not built yet, after
dotnet build
was executed it works fine as expected.I also noticed that for C# this is the exact same behavior.
When this message appears the default namespace "AvaloniaAppTemplate.Namespace" is used.