-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add class templates #29655
add class templates #29655
Conversation
…ova/add_class-tempaltes_7.0.2
…)" This reverts commit 18eb1ab.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
...ed/Microsoft.DotNet.Common.ItemTemplates/content/Class-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
...ed/Microsoft.DotNet.Common.ItemTemplates/content/Class-CSharp/.template.config/template.json
Show resolved
Hide resolved
template_feed/Microsoft.DotNet.Common.ItemTemplates/content/Enum-CSharp/Class1.cs
Outdated
Show resolved
Hide resolved
...eed/Microsoft.DotNet.Common.ItemTemplates/content/Enum-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
...ed/Microsoft.DotNet.Common.ItemTemplates/content/Class-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
...ed/Microsoft.DotNet.Common.ItemTemplates/content/Class-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
I have just few comments I'd like to understand more background about them before signing off
...esTest.struct.langVersion=9.0.targetFramework=netstandard2.0.verified/std-streams/stdout.txt
Outdated
Show resolved
Hide resolved
@@ -50,9 +50,9 @@ jobs: | |||
pool: | |||
vmImage: 'macOS-latest' | |||
${{ if eq(variables['System.TeamProject'], 'public') }}: | |||
helixTargetQueue: OSX.1015.Amd64.Open | |||
helixTargetQueue: OSX.1100.Amd64.Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to the PR: we don't use helix - this should be removed. @GangWang01 could you please check it? Thank you.
...TemplatesTest.struct.langVersion=preview.targetFramework=net7.0.verified/struct/TestItem1.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just consider more test cases (but they can be also added later in separate PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Problem
Related to #28915 and #1713.
New C# item templates are added for creating:
class
interface
record
enum
struct
in existing project
Checks:
[*]Added unit tests
Added #nullable enable to all the modified files N/A