Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class templates #29655

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Dec 22, 2022

Problem

Related to #28915 and #1713.

New C# item templates are added for creating:
class
interface
record
enum
struct
in existing project

Checks:

[*]Added unit tests
Added #nullable enable to all the modified files N/A

@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner December 22, 2022 17:56
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@YuliiaKovalova YuliiaKovalova added the Area-dotnet new the item is related to dotnet new command label Dec 22, 2022
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

I have just few comments I'd like to understand more background about them before signing off

@vlada-shubina vlada-shubina added the Area-Common templates Covers templates in the repo (classlib, console, common item templates) label Dec 23, 2022
@@ -50,9 +50,9 @@ jobs:
pool:
vmImage: 'macOS-latest'
${{ if eq(variables['System.TeamProject'], 'public') }}:
helixTargetQueue: OSX.1015.Amd64.Open
helixTargetQueue: OSX.1100.Amd64.Open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the PR: we don't use helix - this should be removed. @GangWang01 could you please check it? Thank you.

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just consider more test cases (but they can be also added later in separate PR).

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Common templates Covers templates in the repo (classlib, console, common item templates) Area-dotnet new the item is related to dotnet new command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants