Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate n_top_channels to _add_lone_hits #907

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Propagate n_top_channels to _add_lone_hits #907

merged 1 commit into from
Oct 15, 2024

Conversation

HenningSE
Copy link
Collaborator

What is the problem / what does the code in this PR do

Solve #906

@HenningSE HenningSE requested a review from dachengx October 15, 2024 10:26
@HenningSE HenningSE linked an issue Oct 15, 2024 that may be closed by this pull request
n_top_channels always set to 0 #906
Closed
@HenningSE HenningSE mentioned this pull request Oct 15, 2024
Merged
@coveralls
Copy link

Coverage Status

coverage: 90.254%. remained the same
when pulling 7b1a2e1 on fix_lh_merging
into 8843247 on master.

dachengx
dachengx approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HenningSE

@dachengx dachengx merged commit cbc8d57 into master Oct 15, 2024
7 of 8 checks passed
@dachengx dachengx deleted the fix_lh_merging branch October 15, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dachengx dachengx dachengx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

n_top_channels always set to 0
3 participants
@HenningSE @coveralls @dachengx