Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to merge lone_hits into data_start #908

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

HenningSE
Copy link
Collaborator

What is the problem / what does the code in this PR do

This PR is a follow-up of #867 adding the option to merge lone hits into the non-downsampled waveforms.

@HenningSE
Copy link
Collaborator Author

Needs to wait fo #907

@HenningSE HenningSE marked this pull request as ready for review October 15, 2024 10:50
@coveralls
Copy link

coveralls commented Oct 15, 2024

Coverage Status

coverage: 90.198% (-0.06%) from 90.254%
when pulling da9b8be on waveform_start_follow_up
into cbc8d57 on master.

@yuema137 yuema137 self-requested a review October 15, 2024 18:42
yuema137
yuema137 previously approved these changes Oct 15, 2024
Copy link
Collaborator

@yuema137 yuema137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HenningSE it looks good to me.

@dachengx dachengx dismissed yuema137’s stale review October 15, 2024 18:54

The merge-base changed after approval.

@dachengx dachengx changed the title Add option to merge LHs into data_start Add option to merge lone_hits into data_start Oct 16, 2024
@dachengx dachengx merged commit 7bdb03f into master Oct 16, 2024
7 of 8 checks passed
@dachengx dachengx deleted the waveform_start_follow_up branch October 16, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants