[AB#43320] check-finished-ingest-item message dropped #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxTrusov
commented
Apr 29, 2024
services/media/service/src/ingest/handlers/check-finish-ingest-document-handler.ts
Show resolved
Hide resolved
Zehelein
reviewed
Apr 29, 2024
services/media/service/migrations/committed/000026-next-inbox-message-ingest-priority-added.sql
Outdated
Show resolved
Hide resolved
services/media/service/src/ingest/handlers/check-finish-ingest-document-handler.ts
Show resolved
Hide resolved
services/media/service/src/ingest/handlers/video-succeeded-handler.db.spec.ts
Show resolved
Hide resolved
[AB#43320]
Zehelein
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Prerequisites
devfor features andmasterforreleases)
Description
CheckFinishIngestItemcommand dropped in favor of setting ingest item step state directly and makingCheckFinishIngestDocumentupdate ingest item states based on step states in a single update statement.app_hidden.next_inbox_messagesupdated to always try to load 1ingest-documentrelated message (StartIngestorCheckFinishIngestDocument) as a first priority message.Testing notes
Make sure ingest works, same as before (will probably finish a faster, but might only be noticeable with larger ingests)