Skip to content

Commit

Permalink
chore: Add missing jobs to CI end (#4963)
Browse files Browse the repository at this point in the history
`build-docs` and `yarn-project-test` were not requirements of `end`,
which is the job that signals that the CI ended successfully. This
caused PRs to be auto-merged with failing unit tests.

We couldn't flag these two jobs as required in the branch
protection rules for `master` in the project settings, as they are not required to run in the workflow auto-generation if those jobs have a cached artifact.
  • Loading branch information
spalladino authored Mar 5, 2024
1 parent e899e56 commit ff4110e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1514,6 +1514,7 @@ workflows:
- barretenberg-join-split-tests
- barretenberg-acir-tests-bb
- barretenberg-docs
- build-docs
- mainnet-fork
- e2e-2-pxes
- e2e-note-getter
Expand Down Expand Up @@ -1560,6 +1561,7 @@ workflows:
- guides-sample-dapp
- guides-up-quick-start
- yellow-paper
- yarn-project-test
<<: *defaults

# Benchmark jobs.
Expand Down

0 comments on commit ff4110e

Please sign in to comment.