Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add missing jobs to CI end #4963

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore: Add missing jobs to CI end #4963

merged 1 commit into from
Mar 5, 2024

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Mar 5, 2024 •
edited
Loading

build-docs and yarn-project-test were not requirements of end, which is the job that signals that the CI ended successfully. This caused PRs to be auto-merged with failing unit tests.

Alternatively, we could flag these two jobs as required in the branch protection rules for master in the project settings, but I'm unsure how that would play with the workflow auto-generation if those jobs are not required to run.

@spalladino
chore: Add missing jobs to CI end
1e1b3fc 
`build-docs` and `yarn-project-test` were not requirements of `end`,
which is the job that signals that the CI ended successfully. This
caused PRs to be auto-merged with failing unit tests.
ludamad
ludamad approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct way now, as indeed we may fully remove certain jobs. We filter end in the script appropriately. Thanks for doing this

@ludamad ludamad merged commit ff4110e into master Mar 5, 2024
13 checks passed
@ludamad ludamad deleted the palla/add-missing-jobs-to-end branch March 5, 2024 19:29
@AztecBot AztecBot mentioned this pull request Mar 5, 2024
Merged
PhilWindle pushed a commit that referenced this pull request Mar 6, 2024
@AztecBot
chore(master): Release 0.26.1 (#4964)
d0cbd10 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.26.1</summary>

##
[0.26.1](aztec-package-v0.26.0...aztec-package-v0.26.1)
(2024-03-06)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.26.1</summary>

##
[0.26.1](barretenberg.js-v0.26.0...barretenberg.js-v0.26.1)
(2024-03-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.26.1</summary>

##
[0.26.1](aztec-cli-v0.26.0...aztec-cli-v0.26.1)
(2024-03-06)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.26.1</summary>

##
[0.26.1](aztec-packages-v0.26.0...aztec-packages-v0.26.1)
(2024-03-06)


### Features

* Adding fr compatibility to smt variables api
([#4884](#4884))
([c085cbb](c085cbb))
* **avm-simulator:** Implement EMITUNENCRYPTEDLOG
([#4926](#4926))
([5f3304e](5f3304e))
* Choose constructor method in Contract.deploy
([#4939](#4939))
([e899e56](e899e56))
* Indirect mem flag deserialisation
([#4877](#4877))
([4c6820f](4c6820f))


### Miscellaneous

* Add missing jobs to CI end
([#4963](#4963))
([ff4110e](ff4110e))
* **avm-simulator:** Better type env getters
([#4950](#4950))
([8f97977](8f97977))
* **avm-simulator:** Revive field comparison
([#4957](#4957))
([ee21374](ee21374))
* **avm-simulator:** Test improvements
([#4946](#4946))
([f74e6a1](f74e6a1))
* Fix CCI config
([#4974](#4974))
([40178f0](40178f0))
* Remove commitment key copy out of instance
([#4893](#4893))
([6eb6778](6eb6778))
* **vscode:** Add avm-transpiler to vscode rust-analyzer settings
([#4952](#4952))
([db915e5](db915e5))
</details>

<details><summary>barretenberg: 0.26.1</summary>

##
[0.26.1](barretenberg-v0.26.0...barretenberg-v0.26.1)
(2024-03-06)


### Features

* Adding fr compatibility to smt variables api
([#4884](#4884))
([c085cbb](c085cbb))
* Indirect mem flag deserialisation
([#4877](#4877))
([4c6820f](4c6820f))


### Miscellaneous

* Remove commitment key copy out of instance
([#4893](#4893))
([6eb6778](6eb6778))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 7, 2024
@AztecBot
chore(master): Release 0.26.1 (#4964)
aa351ec 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.26.1</summary>

##
[0.26.1](AztecProtocol/aztec-packages@aztec-package-v0.26.0...aztec-package-v0.26.1)
(2024-03-06)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.26.1</summary>

##
[0.26.1](AztecProtocol/aztec-packages@barretenberg.js-v0.26.0...barretenberg.js-v0.26.1)
(2024-03-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.26.1</summary>

##
[0.26.1](AztecProtocol/aztec-packages@aztec-cli-v0.26.0...aztec-cli-v0.26.1)
(2024-03-06)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.26.1</summary>

##
[0.26.1](AztecProtocol/aztec-packages@aztec-packages-v0.26.0...aztec-packages-v0.26.1)
(2024-03-06)


### Features

* Adding fr compatibility to smt variables api
([#4884](AztecProtocol/aztec-packages#4884))
([c085cbb](AztecProtocol/aztec-packages@c085cbb))
* **avm-simulator:** Implement EMITUNENCRYPTEDLOG
([#4926](AztecProtocol/aztec-packages#4926))
([5f3304e](AztecProtocol/aztec-packages@5f3304e))
* Choose constructor method in Contract.deploy
([#4939](AztecProtocol/aztec-packages#4939))
([e899e56](AztecProtocol/aztec-packages@e899e56))
* Indirect mem flag deserialisation
([#4877](AztecProtocol/aztec-packages#4877))
([4c6820f](AztecProtocol/aztec-packages@4c6820f))


### Miscellaneous

* Add missing jobs to CI end
([#4963](AztecProtocol/aztec-packages#4963))
([ff4110e](AztecProtocol/aztec-packages@ff4110e))
* **avm-simulator:** Better type env getters
([#4950](AztecProtocol/aztec-packages#4950))
([8f97977](AztecProtocol/aztec-packages@8f97977))
* **avm-simulator:** Revive field comparison
([#4957](AztecProtocol/aztec-packages#4957))
([ee21374](AztecProtocol/aztec-packages@ee21374))
* **avm-simulator:** Test improvements
([#4946](AztecProtocol/aztec-packages#4946))
([f74e6a1](AztecProtocol/aztec-packages@f74e6a1))
* Fix CCI config
([#4974](AztecProtocol/aztec-packages#4974))
([40178f0](AztecProtocol/aztec-packages@40178f0))
* Remove commitment key copy out of instance
([#4893](AztecProtocol/aztec-packages#4893))
([6eb6778](AztecProtocol/aztec-packages@6eb6778))
* **vscode:** Add avm-transpiler to vscode rust-analyzer settings
([#4952](AztecProtocol/aztec-packages#4952))
([db915e5](AztecProtocol/aztec-packages@db915e5))
</details>

<details><summary>barretenberg: 0.26.1</summary>

##
[0.26.1](AztecProtocol/aztec-packages@barretenberg-v0.26.0...barretenberg-v0.26.1)
(2024-03-06)


### Features

* Adding fr compatibility to smt variables api
([#4884](AztecProtocol/aztec-packages#4884))
([c085cbb](AztecProtocol/aztec-packages@c085cbb))
* Indirect mem flag deserialisation
([#4877](AztecProtocol/aztec-packages#4877))
([4c6820f](AztecProtocol/aztec-packages@4c6820f))


### Miscellaneous

* Remove commitment key copy out of instance
([#4893](AztecProtocol/aztec-packages#4893))
([6eb6778](AztecProtocol/aztec-packages@6eb6778))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@charlielye charlielye Awaiting requested review from charlielye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalladino @ludamad