Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement two missing tests in sequencer-client -> l1-publisher.test.ts #1600

Closed
jeanmon opened this issue Aug 17, 2023 · 1 comment · Fixed by #3915
Closed

Implement two missing tests in sequencer-client -> l1-publisher.test.ts #1600

jeanmon opened this issue Aug 17, 2023 · 1 comment · Fixed by #3915
Assignees
@PhilWindle
Labels
T-testing Type: Testing. More tests need to be added.

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Aug 17, 2023 •
edited
Loading

There are two empty tests named:

  1. 'waits for fee distributor balance'
  2. 'fails if contract is changed underfoot'

This task simply consists in implementing them.

Those tests are related to the following TODOs:

aztec-packages/yarn-project/sequencer-client/src/publisher/l1-publisher.ts

Line 193 in c5f734a

// TODO: Check fee distributor has at least 0.5 ETH.

aztec-packages/yarn-project/sequencer-client/src/publisher/l1-publisher.ts

Line 199 in c5f734a

// TODO: Fail if blockchainStatus.nextBlockNum > thisBlockNum.

@jeanmon jeanmon added the T-testing Type: Testing. More tests need to be added. label Aug 17, 2023
@jeanmon jeanmon added this to A3 Aug 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 17, 2023
@jeanmon jeanmon mentioned this issue Aug 17, 2023
Closed
@spalladino spalladino removed their assignment Aug 18, 2023
@PhilWindle PhilWindle self-assigned this Jan 3, 2024
@PhilWindle
Copy link
Collaborator

I'm simply going to remove these tests. I think they probably came over with the code ported from AC.

@PhilWindle PhilWindle moved this from Todo to In Progress in A3 Jan 10, 2024
@PhilWindle PhilWindle moved this from In Progress to In Review in A3 Jan 10, 2024
@PhilWindle PhilWindle mentioned this issue Jan 10, 2024
Merged
4 tasks
PhilWindle added a commit that referenced this issue Jan 10, 2024
@PhilWindle
feat: Verify state hash is correct before publishing to L1 (#3915)
a53c261 
This PR changes the block publisher to verify the block's start hash is
consistent with that on chain before publishing. It also removes the
redundant test around checking the balance of the fee distributor which
was inherited from aztec connect.

Closes
[this](#1600)
issue.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jan 10, 2024
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @spypsy
Merge pull request #1604 from AztecProtocol/defi-bridge-project
3fbbbd5 
* Modify dev and test rpc urls (#1600)

* Modify dev and test rpc urls

* Fixed typo

* Fixed typo

* kebab custom request method (#1601)

* revert json_rpc_provider changes

* simply forward eth node requests with fetch

* Updated dns entries for dev and testnet mainnet forks (#1603)

Co-authored-by: spypsy <spypsy@users.noreply.github.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@PhilWindle
feat: Verify state hash is correct before publishing to L1 (AztecProt…
a2a1da1 
…ocol#3915)

This PR changes the block publisher to verify the block's start hash is
consistent with that on chain before publishing. It also removes the
redundant test around checking the balance of the fee distributor which
was inherited from aztec connect.

Closes
[this](AztecProtocol#1600)
issue.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilWindle PhilWindle

Labels
T-testing Type: Testing. More tests need to be added.
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Verify state hash is correct before publishing to L1 AztecProtocol/aztec-packages
3 participants
@spalladino @PhilWindle @jeanmon