Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Noir Contract examples to make inter-contract calls via a newly generated Contract Interface #1604

Closed
iAmMichaelConnor opened this issue Aug 17, 2023 · 0 comments · Fixed by #2073 or #2078
Closed

Update Noir Contract examples to make inter-contract calls via a newly generated Contract Interface #1604

iAmMichaelConnor opened this issue Aug 17, 2023 · 0 comments · Fixed by #2073 or #2078
Assignees
@spalladino
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) C-aztec.nr Component: Aztec smart contract framework T-refactor Type: this code needs refactoring

Comments

@iAmMichaelConnor
Copy link
Contributor

We now have contract interfaces, thanks to Santiago.
We should make use of these in all our example contracts, so that they look as clean as possible.
@iAmMichaelConnor iAmMichaelConnor added T-refactor Type: this code needs refactoring A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) labels Aug 17, 2023
@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Aug 25, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Aug 25, 2023
@spalladino spalladino assigned spalladino and unassigned spalladino Sep 4, 2023
@spalladino spalladino mentioned this issue Sep 6, 2023
Merged
spalladino added a commit that referenced this issue Sep 7, 2023
@spalladino
chore(contracts): Use autogenerated Noir interfaces where possible (#…
bd6368b 
…2073)

Fixes #1604
@github-actions github-actions bot mentioned this issue Sep 7, 2023
Merged
PhilWindle pushed a commit that referenced this issue Sep 8, 2023
@github-actions
chore(master): release 0.1.0-alpha63 (#2078)
a5f2852 
🤖 I have created a new Aztec Packages release
---


##
[0.1.0-alpha63](v0.1.0-alpha62...v0.1.0-alpha63)
(2023-09-08)


### Features

* `GrumpkinScalar` type
([#1919](#1919))
([3a9238a](3a9238a))


### Bug Fixes

* add retry to tag and docker actions
([#2099](#2099))
([9f741f4](9f741f4))
* **breaking change:** change embedded curve scalar mul to use two limbs
to properly encode the scalar field
([#2105](#2105))
([070cc4c](070cc4c))
* broken bootstrap.sh after renaming `aztec-cli` dir as `cli`
([#2097](#2097))
([2386781](2386781))
* browser test in canary flow
([#2102](#2102))
([d52af6c](d52af6c)),
closes
[#2086](#2086)
* check a note is read before nullifying it.
([#2076](#2076))
([aabfb13](aabfb13)),
closes
[#1899](#1899)
* circuits issues when building with gcc
([#2107](#2107))
([4f5c4fe](4f5c4fe))
* COMMIT_TAG arg value in canary Dockerfile
([#2118](#2118))
([a3d6459](a3d6459))
* dont assume safety of nvm
([#2079](#2079))
([a4167e7](a4167e7))
* end-to-end aztec cli dependency issue
([#2092](#2092))
([16ee3e5](16ee3e5))
* minor annoyances
([#2115](#2115))
([a147582](a147582))
* padded printing for e2e-cli
([#2106](#2106))
([5988014](5988014))
* remaining refs to clang15
([#2077](#2077))
([2c16547](2c16547))
* run e2e tests without spot
([#2081](#2081))
([f0aa3ca](f0aa3ca))
* updated CLI readme
([#2098](#2098))
([2226091](2226091)),
closes
[#1784](#1784)


### Miscellaneous

* **circuits:** - remove dead code from cbind of private kernel circuit
([#2088](#2088))
([43dc9d7](43dc9d7))
* **circuits:** remove dead code in cbind.cpp for public kernel
([#2094](#2094))
([861f960](861f960))
* Conservatively raise the minimum supported clang version in CMakeList
([#2023](#2023))
([f49c416](f49c416))
* **constants:** bump number of private reads and writes
([#2062](#2062))
([ab6c6b1](ab6c6b1))
* **contracts:** Use autogenerated Noir interfaces where possible
([#2073](#2073))
([bd6368b](bd6368b)),
closes
[#1604](#1604)
* merge bb release-please
([#2080](#2080))
([e89b043](e89b043))
* move storage into main.nr.
([#2068](#2068))
([2c2d72b](2c2d72b))
* protogalaxy relations
([#1897](#1897))
([35407e2](35407e2))


### Documentation

* **limitations:** limitations on ordering and logs of chopped notes
([#2085](#2085))
([315ad3d](315ad3d)),
closes
[#1652](#1652)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @spypsy
Merge pull request #1604 from AztecProtocol/defi-bridge-project
3fbbbd5 
* Modify dev and test rpc urls (#1600)

* Modify dev and test rpc urls

* Fixed typo

* Fixed typo

* kebab custom request method (#1601)

* revert json_rpc_provider changes

* simply forward eth node requests with fetch

* Updated dns entries for dev and testnet mainnet forks (#1603)

Co-authored-by: spypsy <spypsy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalladino spalladino

Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) C-aztec.nr Component: Aztec smart contract framework T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@spalladino @iAmMichaelConnor