Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable wasm compiling #1630

Closed
spalladino opened this issue Aug 17, 2023 · 1 comment
Closed

Re-enable wasm compiling #1630

spalladino opened this issue Aug 17, 2023 · 1 comment

Comments

@spalladino
Copy link
Collaborator

In #1628 we remove the option of building with noir_wasm, since noir-source-resolver was causing issues when being imported simultaneously via esm (from a3-packages) and commonjs (from noir_wasm).

We should revisit this issue: make the necessary changes in both noir_wasm and noir-source-resolver (making sure we don't accidentally break other uses), ensure that the noir_wasm that corresponds to the aztec version is published consistently (the publishing job is failing at the time of this writing), and revert #1628. If this works, we should also make wasm the default choice for compiling, and remove nargo as a prerequisite from the compile guide.

@spalladino
Copy link
Collaborator Author

Closing as duplicate of #2644

@spalladino spalladino closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant