chore(compiler): Remove wasm option from noir compiler #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @noir-lang/noir-source-resolver@1.1.1, @noir-lang/noir_wasm@0.5.1-9740f54 |
sirasistant
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1597 was preventing users from installing the Aztec CLI via npm.
Releasing a new version of
noir_wasmandnoir-source-resolverdidn't fix the issue unfortunately, and further tweakingnoir-source-resolverso it's loaded properly leads to errors due since the resolver is a global object but it's treated as different objects when loaded as commonjs or esm. So the noir-compiler here is properly configuring the resolver in esm-land, but noir_wasm loads it via commonjs and fails. To make things worse, jest seems to be complaining about misconfigured esm modules here.Given that noir_wasm is not kept up-to-date atm and is not the recommended way to compile noir contracts, I decided to time out and remove it altogether for now. I'm creating a new issue to revisit this in the future.
Fixes #1597