Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate noir-wasm into aztec-cli for contract compilation #2644

Closed
5 tasks done
PhilWindle opened this issue Oct 3, 2023 · 0 comments · Fixed by #2737
Closed
5 tasks done

Incorporate noir-wasm into aztec-cli for contract compilation #2644

PhilWindle opened this issue Oct 3, 2023 · 0 comments · Fixed by #2737
Assignees
@alexghr

Comments

@PhilWindle
Copy link
Collaborator

PhilWindle commented Oct 3, 2023 •
edited by alexghr
Loading

Tasks
Preview Give feedback
  1. chore: Add visibility modifiers #2728
  2. fix: add pub modifier to grumpkin functions noir-lang/noir#3036
  3. feat: publish aztec build of noir_wasm noir-lang/noir#3049
  4. feat: return compilation errors from noir_wasm noir-lang/noir#3091
  5. feat: noir-wasm takes dependency graph noir-lang/noir#3213
@PhilWindle PhilWindle added this to A3 Oct 3, 2023
@PhilWindle PhilWindle converted this from a draft issue Oct 3, 2023
@alexghr alexghr moved this from Todo to In Progress in A3 Oct 4, 2023
This was referenced Oct 9, 2023
Merged
Merged
Merged
Merged
alexghr added a commit that referenced this issue Oct 10, 2023
@alexghr
fix: default export in noir-version (#2757)
6ff7bed 
alternative to #2751 until #2644 is closed.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@spalladino spalladino mentioned this issue Oct 10, 2023
Closed
@alexghr alexghr moved this from In Progress to Blocked in A3 Oct 16, 2023
This was referenced Oct 18, 2023
Closed
Closed
@alexghr alexghr moved this from Blocked to In Progress in A3 Oct 25, 2023
@alexghr alexghr moved this from In Progress to In Review in A3 Oct 27, 2023
alexghr added a commit that referenced this issue Oct 27, 2023
@alexghr @spalladino
feat: compile noir contracts with noir_wasm (#2737)
524cecf 
This PR adds support for compiling contracts with `noir_wasm` instead of
`nargo`.

Fix #2644

Requires:
- [x] #2728
- [x] noir-lang/noir#3036
- [x] noir-lang/noir#3049
- [x] noir-lang/noir#3091
- [x] noir-lang/noir#3213
- [x] updates to `noir-contracts` to add `pub` modifiers to return types
(TBD)
e.g. `getThisAddress() -> pub Field` here
https://github.com/AztecProtocol/aztec-packages/blob/4881414ceb30590674c244ef9bc4c8416eacd6bc/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr#L45
- [x] build `noir_wasm` with `aztec` feature enabled (based on
noir-lang/noir#3049)
- [x] output compilation errors (based on noir-lang/noir#3091)

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexghr alexghr

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: compile noir contracts with noir_wasm AztecProtocol/aztec-packages
2 participants
@alexghr @PhilWindle