Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aztec Connect Style Uniswap Bridge #2167

Closed
8 of 9 tasks
LHerskind opened this issue Sep 11, 2023 · 1 comment
Closed
8 of 9 tasks

Aztec Connect Style Uniswap Bridge #2167

LHerskind opened this issue Sep 11, 2023 · 1 comment
Assignees
@rahul-kothari
Labels
T-tracking Type: Tracking Issue. This contains tasklists.

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 11, 2023 •
edited by rahul-kothari
Loading

Goal: Support something similar to Aztec connect in function that uses L2 to aggregate

Extension of #843 with a prior issue at #879, updated here to elaborate on the tasks for clarity.

Tasks
Beta Give feedback
  4. Address failure cases #2493
    rahul-kothari
  6. Write a dev-guide for AC Uniswap portal #2173
    rahul-kothari
  7. Replace NonNativeToken everywhere + update token portal #2291
    rahul-kothari

Dependencies
Beta Give feedback
  1. Token interfaces and standard-ish #1743
    2 of 2
    discussion-needed
    LHerskind
  2. Write token portal for Standard token. #2170
    1 of 1
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 11, 2023
@LHerskind LHerskind added the T-tracking Type: Tracking Issue. This contains tasklists. label Sep 11, 2023
@LHerskind LHerskind added this to the 📢 Initial Public Sandbox Release milestone Sep 11, 2023
This was referenced Sep 14, 2023
Closed
Closed
Merged
rahul-kothari added a commit that referenced this issue Sep 19, 2023
@rahul-kothari
feat(token portal standard): Create a token portal standard (#2351)
426a3ea 
Part of #2167 - creates the tokenPortal Standard + updates cross chain
tests (and cross chain harness file)
Doc is TBD

* moved address types to aztec-nr 
* Created #2291 - where I will purge `NonNativeToken`
* In a future PR, I will update uniswap portal too. For now I have
skipped the uniswap test (to keep this PR small-ish) as it uses
`crosschainHarness` which is integral to the other cross-chain e2e tests
* I have created a separate public/private flow for depositing to Portal
(and therefore separate flow for cancelling such L1->L2 messages)
*
This was referenced Sep 25, 2023
Closed
Closed
This was referenced Sep 26, 2023
Open
Merged
rahul-kothari added a commit that referenced this issue Sep 29, 2023
@rahul-kothari
feat: uniswap private flow (#2559)
39f3a91 
Part of #2167 - create the private flow for uniswap

This is already a large PR so omitted failure cases and public flow.
* UniswapPortal.sol -> has a separate flow for public and private.
Updated relevant tests too
* Uniswap aztec-nr contract -> just the private flow for now. 
* Deleted the sandbox example
* Updated e2e uniswap test with the private flow. Failure cases and
public flow will be in a separate PR
* Update the canary test
* 
**Also comments out base rollup check on public data reads as explained
in #2521**
@rahul-kothari rahul-kothari mentioned this issue Oct 2, 2023
Merged
rahul-kothari added a commit that referenced this issue Oct 6, 2023
@rahul-kothari
chore(uniswap_tests): test edge cases around uniswap flow (#2620)
7a58fe9 
Fix #2493. Part of #2167 
* Adds test cases for both public, private flow
* Found an edge case that wasn't tested in l1<>l2 tests so added those
too
* Also rename `swap` to `swap_private`

Runtime currently is ~5 mins
@iAmMichaelConnor iAmMichaelConnor removed this from the 📢 Initial Public Sandbox Release milestone Oct 27, 2023
@LHerskind
Copy link
Contributor Author

Closing this for now as it have no priority at the moment.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
T-tracking Type: Tracking Issue. This contains tasklists.
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LHerskind @rahul-kothari @iAmMichaelConnor