feat: L2 aggregation for uniswap L1 swap #1796
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #879 and supports aggregation using public functions where the user can later claim funds in private. It is not full aztec connect style, but almost.
Bridged assets have too high precision for noir to handle 😬 Both dai and weth are 1e18 but we want the u120 to do math on them which is running into trouble when multiplying. To avoid the issue, i'm reducing the precision of input assets by
1e9
in the share computation.BROKEN
This PR was broken after changes to how the unshielding work in underlying token implementation. Earlier they were requiring only knowledge of the pre-image and ability to create the nullifier, now they also depend on the contract coming from a specific msg_sender. This makes the flow in both the lending and this contract broken since they were using this structure before 🤷. As alluded to in #1743 a standard should be made.
Since only some assets where updated, there are really two paths to this case.
Consider the discussion that @spalladino and I had in https://discourse.aztec.network/t/account-guardians-eip1271-and-recursive-proofs/675
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.