Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contract-deploy] Verify that initialization arguments match address preimage #5154

Closed
Tracked by #4052
spalladino opened this issue Mar 12, 2024 · 0 comments · Fixed by #5144
Closed
Tracked by #4052

[contract-deploy] Verify that initialization arguments match address preimage #5154

spalladino opened this issue Mar 12, 2024 · 0 comments · Fixed by #5144

Comments

@spalladino
Copy link
Collaborator

spalladino commented Mar 12, 2024

The responsibility to check that the initialization arguments used when calling the initializer as correct is responsibility of the initializer itself. Without this check, a deployer could commit to a set of init args in the address preimage, but then call the initializer using something totally different.

@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 12, 2024
spalladino added a commit that referenced this issue Mar 13, 2024
The responsibility to check that the initialization arguments used when
calling the initializer as correct is responsibility of the initializer
itself. Without this check, a deployer could commit to a set of init
args in the address preimage, but then call the initializer using
something totally different.

Fixes #5154

---------

Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant