feat: Check initialization arguments in constructors

[spalladino]

The responsibility to check that the initialization arguments used when calling the initializer as correct is responsibility of the initializer itself. Without this check, a deployer could commit to a set of init args in the address preimage, but then call the initializer using something totally different.

Fixes #5154

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 94922fc2 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,004	238,840	469,544
l1_rollup_execution_gas	666,636	953,701	1,336,852
l2_block_processing_time_in_ms	1,294 (+1%)	4,935 (+4%)	9,107 (+2%)
note_successful_decrypting_time_in_ms	132 (-7%)	526 (-7%)	991 (+5%)
note_trial_decrypting_time_in_ms	38.9 (-16%)	30.7 (-62%)	123 (+62%)
l2_block_building_time_in_ms	17,039 (+1%)	67,630 (+1%)	135,097 (+1%)
l2_block_rollup_simulation_time_in_ms	7,018 (+1%)	27,875	55,828
l2_block_public_tx_process_time_in_ms	9,992 (+1%)	39,698 (+1%)	79,165 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,755 (-2%)	26,413 (-1%)
note_history_successful_decrypting_time_in_ms	1,210 (-6%)	2,421 (-2%)
note_history_trial_decrypting_time_in_ms	67.9 (-35%)	129 (-18%)
node_database_size_in_bytes	19,062,864	35,930,192 (+1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	280 (+1%)	44,338	27,700
private-kernel-ordering	218 (+1%)	52,324	14,326
base-rollup	635	177,083	925
root-rollup	68.4 (+1%)	4,176	789
private-kernel-inner	638 (+2%)	73,197	27,700
public-kernel-app-logic	439	35,198	28,215
public-kernel-tail	176	40,926	28,215
merge-rollup	8.35 (+1%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.97	16.1 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.581 (+1%)	0.497 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.9	72.0	231 (+1%)	444	869 (+1%)	1,726 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.472	0.444	0.421	0.416 (+1%)	0.414 (+1%)	0.414 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.6 (-1%)	107 (+1%)	338 (+2%)	659	1,312 (+1%)	2,603 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.478	0.482 (+1%)	0.459 (+1%)	0.454 (+1%)	0.455	0.453	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.3 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.537 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,014

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	4,212 (+6%)	1,741 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	12.5 (+2%)	1,230

[alexghr]

❤️