Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Keys_Nullifier): Update owned notes to contain Npk_m instead of owner #5630

Closed
Tracked by #5606
benesjan opened this issue Apr 9, 2024 · 0 comments · Fixed by #6130 or #6405
Closed
Tracked by #5606

feat(Keys_Nullifier): Update owned notes to contain Npk_m instead of owner #5630

benesjan opened this issue Apr 9, 2024 · 0 comments · Fixed by #6130 or #6405
Assignees

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 9, 2024

To allow for rotation of nullifier keys we will need to store nullifier public key instead of owner in a note. This is to prevent the possibility of double spend in case the keys are rotated (user could spend the note, rotate the keys and spend the note again --> different nullifier would be created).

This requires changes to the oracle

@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 9, 2024
@sklppy88 sklppy88 changed the title Update Token contract and TokenNote such that it contains Npk_m instead of owner Update all notes and contract such that it contains Npk_m instead of owner Apr 29, 2024
@sklppy88 sklppy88 changed the title Update all notes and contract such that it contains Npk_m instead of owner Update all notes and contracts such that it contains Npk_m instead of owner Apr 29, 2024
@sklppy88 sklppy88 changed the title Update all notes and contracts such that it contains Npk_m instead of owner Update token note and token contract such that it contains Npk_m instead of owner May 1, 2024
@LHerskind LHerskind changed the title Update token note and token contract such that it contains Npk_m instead of owner feat(Keys_Misc): Update owned notes to contain Npk_m instead of owner May 1, 2024
@LHerskind LHerskind changed the title feat(Keys_Misc): Update owned notes to contain Npk_m instead of owner feat(Keys_Nullifier): Update owned notes to contain Npk_m instead of owner May 1, 2024
@sklppy88 sklppy88 moved this from Todo to In Review in A3 May 4, 2024
@sklppy88 sklppy88 moved this from In Review to In Progress in A3 May 4, 2024
@sklppy88 sklppy88 linked a pull request May 8, 2024 that will close this issue
@sklppy88 sklppy88 moved this from In Progress to In Review in A3 May 10, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 May 15, 2024
sklppy88 added a commit that referenced this issue May 16, 2024
Resolves #6313
Resolves #6296
Resolves #5630

Have created #6417 to refactor the rotate call

---------

Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment