Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add a call to registry in rotate nullifying key in wallet and clean the rest of comments on #6405 #6417

Closed
sklppy88 opened this issue May 15, 2024 · 0 comments · Fixed by #6450
Closed

refactor: add a call to registry in rotate nullifying key in wallet and clean the rest of comments on #6405 #6417

sklppy88 opened this issue May 15, 2024 · 0 comments · Fixed by #6450
Assignees
@sklppy88

Comments

@sklppy88
Copy link
Contributor

See #6405
@github-project-automation github-project-automation bot moved this to Todo in A3 May 15, 2024
@sklppy88 sklppy88 mentioned this issue May 15, 2024
Merged
@sklppy88 sklppy88 self-assigned this May 15, 2024
@sklppy88 sklppy88 changed the title refactor: add a call to registry in rotate nullifying key in wallet refactor: add a call to registry in rotate nullifying key in wallet and clean the rest of comments on #6405 May 16, 2024
sklppy88 added a commit that referenced this issue May 16, 2024
@sklppy88 @benesjan
feat: npk_m_hash in all notes + key rotation test (#6405)
74e98d4 
Resolves #6313
Resolves #6296
Resolves #5630

Have created #6417 to refactor the rotate call

---------

Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
@sklppy88 sklppy88 mentioned this issue May 16, 2024
Merged
@sklppy88 sklppy88 linked a pull request May 17, 2024 that will close this issue
refactor: refactor key rotate and address comments from 6405 #6450
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: refactor key rotate and address comments from 6405 AztecProtocol/aztec-packages
1 participant
@sklppy88