Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Event_Logs): Handle wrapper that check contract address match #6535

Closed
Tracked by #5606
LHerskind opened this issue May 20, 2024 · 1 comment · Fixed by #6921
Closed
Tracked by #5606

feat(Event_Logs): Handle wrapper that check contract address match #6535

LHerskind opened this issue May 20, 2024 · 1 comment · Fixed by #6921
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented May 20, 2024

We should have functionality similar to the l1_payload for notes that can be used for the event logs to ensure that the values are decrypted and that the kernel provided address matches the address in the headers. See #6537.

Furthermore, we should be able to spit out values that can be decoded using the contract artifact for the event such that it is a meaningful value for the user.

For example, or a series of fields, returning Transfer(from, to, amount) if a Transfer event is decoded.

@LHerskind
Copy link
Contributor Author

Keep in mind #[event] vs #[abi(event)]

@sklppy88 sklppy88 linked a pull request Jun 6, 2024 that will close this issue
sklppy88 added a commit that referenced this issue Jun 10, 2024
Notable limitations to be discussed and / or addressed in a future PR.

Currently our events decoder supports only an event of fields.

This stack addresses #6535 and #6530.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants