feat: splitting event log functionality

[sklppy88]

Notable limitations to be discussed and / or addressed in a future PR.

Currently our events decoder supports only an event of fields.

This stack addresses #6535 and #6530.

[sklppy88]

• feat: pxe can filter on emitted events #6947
• feat: splitting event log functionality #6921 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 72.8 (-86%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 200 (+254%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-tail): 1,799 (-20%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,704	1,546	696	759 (-1%)	779 (+2%)
proof_construction_time_sha256_30_ms	11,430	3,044	1,370	1,437 (+1%)	1,461 (+1%)
proof_construction_time_sha256_100_ms	44,534	11,990	5,648	5,536 (-1%)	5,463
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0 (-2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,516	417	201	224	267 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,720	1,557	719 (-1%)	778 (-1%)	790 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,460	9,452
l1_rollup_execution_gas	610,285	610,281	610,273
l2_block_processing_time_in_ms	677 (-2%)	1,283	2,393 (-3%)
l2_block_building_time_in_ms	21,983 (-2%)	45,677	86,463 (-2%)
l2_block_rollup_simulation_time_in_ms	21,878 (-2%)	45,324	86,069 (-2%)
l2_block_public_tx_process_time_in_ms	18,821 (-2%)	41,915	82,824 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	5,896	8,508 (+1%)
node_database_size_in_bytes	9,461,840	12,701,776
pxe_database_size_in_bytes	9,242	15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	132 (-2%)	465 (+2%)	12,838	20,634	64,614	89,536	2,731	524,288
private-kernel-inner	394 (+2%)	973 (+2%)	49,285	92,326	64,614	89,536	2,731	2,097,152
private-kernel-tail	366 (-1%)	⚠️ 1,799 (-20%)	47,550	96,545	69,406	11,648	297	2,097,152
base-parity	6.56 (+2%)	1,767 (+5%)	2,657	128	64.0	2,208	2.00	131,072
root-parity	49.2	63.4 (-1%)	39,635 (-8%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,528 (-1%)	2,413	84,696 (-2%)	119,738	756	3,648	47.0	4,194,304
root-rollup	117 (+7%)	77.5 (-6%)	21,820 (-1%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	691 (+2%)	2,708 (+1%)	42,246 (-4%)	108,585	86,550	116,768	3,582	2,097,152
public-kernel-app-logic	565 (-1%)	3,446 (+1%)	46,182 (+3%)	108,585	86,550	116,768	3,582	2,097,152
public-kernel-tail	1,135	22,929 (+3%)	180,793	403,238	7,646	11,648	297	8,388,608
private-kernel-reset-small	589 (+1%)	1,944 (+1%)	47,025	120,737	64,614	89,536	2,731	2,097,152
public-kernel-teardown	584 (+2%)	3,547 (+2%)	45,902 (+3%)	108,585	86,550	116,768	3,582	2,097,152
merge-rollup	28.6 (-1%)	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,979 (+2%)	53,621	N/A	N/A	116,768	3,582	2,097,152
avm-circuit	N/A	N/A	783 (-3%)	N/A	N/A	83,008	0.00	0.00

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	491 (+7%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	41.4 (+3%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	2,046 (+3%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	1,003	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,421 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,859 (+1%)	16,768	54,089	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,633 (+3%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	1,073 (+3%)	16,768	11,031 (-1%)	524,288	457
Token:transfer	1,376	9,944	5,602 (+5%)	16,768	52,553 (-1%)	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,401	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	76.3	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,941 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,864 (+1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms
GasToken:_increase_public_balance	67.7 (-1%)
GasToken:set_portal	17.9 (-11%)
Token:constructor	94.3 (+1%)
FPC:constructor	61.1
GasToken:mint_public	52.5 (-2%)
Token:mint_public	⚠️ 72.8 (-86%)
Token:assert_minter_and_mint	⚠️ 200 (+254%)
SchnorrAccount:approve_public_authwit	32.0 (-13%)
FPC:prepare_fee	86.4 (+17%)
Token:transfer_public	58.5 (-7%)
FPC:pay_refund	64.5 (-6%)
Benchmarking:increment_balance	2,397 (-1%)
Token:_increase_public_balance	56.1 (-1%)
FPC:pay_refund_with_shielded_rebate	52.7 (-8%)

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.178 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.9	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.605	0.516	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.3	74.8 (-2%)	130 (-3%)	246	461 (-3%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	288	543	1,055	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.493	0.461 (-2%)	0.444 (-3%)	0.446	0.431 (-3%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.3	111 (-2%)	178 (-4%)	354	678 (-3%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	208	355	691	1,363	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.502	0.497 (-2%)	0.472 (-3%)	0.480	0.466 (-3%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	59.9 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	103
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.545 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	79,300	673,633

Transaction size based on fee payment method

| Metric | |
| - | |

[LHerskind]

Think we should be able to get rid of some of the redundancy around the decryption and encryption, and then we should be able to use macros to make it neater.

There are some checks skipped that you don't need to skip as you can use data from the outgoing header as well

[LHerskind]

I think we would be able to do something like the notes where we can get it to produce the event_type_id so we do not need to pass it along. This enabled the "simpler" flow in https://github.com/AztecProtocol/aztec-packages/pull/6432/files where we can throw the note/event in and then have it provide much of the information on its own.

[LHerskind]

event_type_id should be possible to get from just the selector() that is currently created for #[aztec(event)]. Simplifies the interface slightly. Niche in here as it is just a test, but think would be neat to reduce the number of inputs 👍

[sklppy88]

Good point. Have addressed, but put it under _selector for now as to not conflict w/ the current macro.

[LHerskind]

We need to make this macro yes? It was not already there right?

Also, I think we reuse quite a bit from our note macro, and have it use the same structure. Then we don't need to provide anything for the event type id, we just derive it 👍

    // Autogenerated by the #[aztec(event)] macro unless it is overridden by a custom implementation
    fn get_event_type_id()_ -> Field;

    // Autogenerated by the #[aztec(event)] macro unless it is overridden by a custom implementation
    fn to_be_bytes(self, randomness: Field) -> [u8; M];

Similar code is seen in the note_interface.rs in the macros.

Created #6951 to look at this.

[LHerskind]

If you could use the note selector that we already got available I think it would be great, and likely be easier to update with the macros after since we will need that changed anyhow.

[LHerskind]

event_type_id should be possible to get from just the selector() that is currently created for #[aztec(event)]. Simplifies the interface slightly. Niche in here as it is just a test, but think would be neat to reduce the number of inputs 👍

[LHerskind]

Add selector which we are currently autogenerating in event.rs for #[aztec(event)]. Then we don't need to provide the event_type_id to to_be_bytes.

[sklppy88]

Have addressed. Agree that it makes this much cleaner.

[LHerskind]

Would probably be good for us to use note and event in the naming here as they are currently both needed to be the same to really work which seems easy to mess up 🤷

[sklppy88]

Good point. And with the eventId change to autocalculate the selector, it was a natural change.

[LHerskind]

If we have the macros think we can for now just have it inside the same file as it is a minor diff then.

[sklppy88]

This was modified because this is the actual value in nr